Resolve OOF layout against inline containing blocks - #810
Open
nicoburns wants to merge 2 commits into
Open
Conversation
Contributor
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolve absolute/fixed descendants against non-atomic inline containing blocks within the same inline formatting context, on top of #809.
The inline root remains the Taffy geometry owner and structural ancestry is unchanged. Final Parley items are scanned only when an inline catches OOF candidates, retaining constant-size first/last fragment state; grouped candidates are then laid out through Taffy's explicit
OofPositioningAreaAPI. Exceptional{ child, containing_block }identity is retained on the inline root rather than adding another field to every node.This intentionally leaves empty-inline boundary geometry and block-in-inline continuations for follow-up work. Depends on DioxusLabs/taffy#1174.
Link to Devin session: https://dioxus.staging.devinenterprise.com/sessions/b6714d5757fa4fa7b858caed09087cdb
Open in Devin Desktop: https://dioxus.staging.devinenterprise.com/desktop/session/b6714d5757fa4fa7b858caed09087cdb?variant=devin-insiders
Requested by: @nicoburns
WPT results
145 newly passing, 36 newly failing (net +109).
Full diff (181 changed tests)
Generated by the WPT workflow.