fix(ddprof_live_heap): remove startup printf to improve heap profile accuracy - #209
Open
r1viollet wants to merge 1 commit into
Open
fix(ddprof_live_heap): remove startup printf to improve heap profile accuracy#209r1viollet wants to merge 1 commit into
r1viollet wants to merge 1 commit into
Conversation
…accuracy Remove diagnostic printf that was creating a persistent stdio buffer allocation. This accounted for ~8% of in-use memory, causing leak_function to measure at 91% instead of 100%. The test objective is to validate leak profiling accuracy, not test printf output. Removing this output improves test precision and maintains 5% margin expectations.
r1viollet
force-pushed
the
r1viollet/ddprof-live-heap-remove-printf
branch
from
September 8, 2026 07:57
f3c701c to
0650235
Compare
IlyasShabi
approved these changes
Sep 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove diagnostic printf that was creating a persistent stdio buffer allocation,
accounting for ~8% of in-use memory and causing leak_function to measure at 91%
instead of 100%.
Root cause: The startup printf creates a stdio buffer that persists in
memory. As seen in the CI profile data:
The test objective is to validate leak profiling accuracy, not test printf
output. Removing this output improves test precision and eliminates the need
for wider error margins.
Better than PR #207 which widens margins - this directly fixes the root cause.