Skip to content

chore(lint): slim ruff ruleset and consolidate lint scripts - #175

Open
r1viollet wants to merge 1 commit into
mainfrom
r1viollet/lint-ergonomics
Open

chore(lint): slim ruff ruleset and consolidate lint scripts#175
r1viollet wants to merge 1 commit into
mainfrom
r1viollet/lint-ergonomics

Conversation

@r1viollet

Copy link
Copy Markdown
Collaborator

Description

Follow-up to #174 based on usage:

  • Relax the ruff ruleset to a low-noise core (F, E, W, I, UP, B), dropping the strict/opinionated rules (ANN, S, PL, PERF, EM, pydocstyle/D, N, C90, ...) that add friction on scenario workloads.
  • Drop dead config: D-rule ignores/per-file-ignores and pydocstyle config referenced rules that were never selected.
  • Collapse scripts/lint + scripts/format + scripts/ruff-common.sh into a single 'scripts/ruff {check|fix}'.
  • Fix scripts/ruff fix: 'ruff check --fix' exits non-zero on remaining unfixable lints, which under 'set -e' aborted before formatting ran, leaving files unformatted. Now formatting always runs.
  • Point CI, README, and pre-commit at the single script.

@r1viollet
r1viollet requested a review from a team as a code owner July 28, 2026 14:27
Comment thread pyproject.toml Outdated
Follow-up to #174 based on review feedback:

- Keep the existing ruff ruleset (per review, the strict set is fine).
- Remove only dead config: the D-rule ignores/per-file-ignores and the
  pydocstyle section referenced rules that were never in select, so they
  had no effect. No change to what is actually enforced.
- Collapse scripts/lint + scripts/format + scripts/ruff-common.sh into a
  single 'scripts/ruff {check|fix}'.
- Fix scripts/ruff fix: 'ruff check --fix' exits non-zero on remaining
  unfixable lints, which under 'set -e' aborted before formatting ran,
  leaving files unformatted. Now formatting always runs.
- Point CI, README, and pre-commit at the single script.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants