Skip to content

ci(riot): schedule Python 3.15 jobs for 'smoke_test.py ' (PROF-14439) - #19906

Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 6 commits into
mainfrom
vlad/py315-riotfile
Sep 4, 2026
Merged

ci(riot): schedule Python 3.15 jobs for 'smoke_test.py ' (PROF-14439)#19906
gh-worker-dd-mergequeue-cf854d[bot] merged 6 commits into
mainfrom
vlad/py315-riotfile

Conversation

@vlad-scherbich

@vlad-scherbich vlad-scherbich commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

Description

Delta vs #19267.

Adds (3, 15) to SUPPORTED_PYTHON_VERSIONS and opts smoke_test / sourcecode into 3.15. Default MAX_PYTHON_VERSION stays "3.14".

Does not widen requires-python. Does not enable wrap() on 3.15.

Testing

scripts/lint riot and scripts/lint style riotfile.py.

Risks

smoke_test is required by build_base_venvs whenever 3.15 is in the matrix.

Additional Notes

No release note: CI chore, changelog/no-changelog.

Contributes to #17816

@vlad-scherbich vlad-scherbich added the changelog/no-changelog A changelog entry is not required for this PR. label Aug 27, 2026
@cit-pr-commenter-54b7da

cit-pr-commenter-54b7da Bot commented Aug 27, 2026

Copy link
Copy Markdown

Codeowners resolved as

Resolved from the full PR diff against main using the target branch CODEOWNERS file.
CODEOWNERS team requests not listed below are not required by the current file set.

No remaining files require a CODEOWNERS review.

@cit-pr-commenter-54b7da

cit-pr-commenter-54b7da Bot commented Aug 27, 2026

Copy link
Copy Markdown

Circular import analysis

⚠️ Existing circular imports

There are 3 circular imports that already exist on the base branch and have not been changed by this PR.

ddtrace.llmobs -> ddtrace.llmobs._evaluators -> ddtrace.llmobs._evaluators.format -> ddtrace.llmobs._experiment -> ddtrace.llmobs
ddtrace.errortracking._handled_exceptions.bytecode_injector -> ddtrace.errortracking._handled_exceptions.callbacks -> ddtrace.errortracking._handled_exceptions.collector -> ddtrace.errortracking._handled_exceptions.bytecode_reporting -> ddtrace.errortracking._handled_exceptions.bytecode_injector
ddtrace.appsec._asm_request_context -> ddtrace.appsec._iast._iast_request_context_base -> ddtrace.appsec._iast._iast_env -> ddtrace.appsec._iast.reporter -> ddtrace.appsec._exploit_prevention.stack_traces -> ddtrace.appsec._asm_request_context

@cit-pr-commenter-54b7da

cit-pr-commenter-54b7da Bot commented Aug 27, 2026

Copy link
Copy Markdown

Dependency direction analysis

⚠️ Existing dependency direction violations

There are 230 dependency direction violations that already exist on the base branch and have not been changed by this PR.

Show existing violations (showing 5 of 230 highest severity)
ddtrace.internal.tracemethods -×-> ddtrace.trace  (internal-core -> product:tracing, score=134)
ddtrace.debugging._exception.replay -×-> ddtrace.trace  (product:debugging -> product:tracing, score=132)
ddtrace.internal.opentelemetry.span -×-> ddtrace.trace  (product:opentelemetry -> product:tracing, score=132)
ddtrace.profiling.collector.stack -×-> ddtrace.trace  (product:profiling -> product:tracing, score=132)
ddtrace.llmobs._integrations.vertexai -×-> ddtrace.trace  (product:llmobs -> product:tracing, score=132)

To see all violations, download the layers-base.json and layers-pr.json artifacts from this CI job and run:

uv run --script scripts/import-analysis/layers.py compare layers-base.json layers-pr.json

@datadog-prod-us1-5

datadog-prod-us1-5 Bot commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

Tests

🎉 All green!

🧪 All tests passed
❄️ No new flaky tests detected

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 8c7799f | Docs | View more details | Give us feedback!

@pr-commenter

pr-commenter Bot commented Aug 27, 2026

Copy link
Copy Markdown

Benchmarks

Benchmark execution time: 2026-09-04 19:32:16

Comparing candidate commit 8c7799f in PR branch vlad/py315-riotfile with baseline commit d639f30 in branch main.

📊 Benchmarking dashboard

Found 0 performance improvements and 7 performance regressions! Performance is the same for 576 metrics, 10 unstable metrics, 2 known flaky benchmarks, 16 flaky benchmarks without significant changes.

Explanation

This is an A/B test comparing a candidate commit's performance against that of a baseline commit. Performance changes are noted in the tables below as:

  • 🟩 = significantly better candidate vs. baseline
  • 🟥 = significantly worse candidate vs. baseline

We compute a confidence interval (CI) over the relative difference of means between metrics from the candidate and baseline commits, considering the baseline as the reference.

If the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD), the change is considered significant.

Feel free to reach out to #apm-benchmarking-platform on Slack if you have any questions.

More details about the CI and significant changes

You can imagine this CI as a range of values that is likely to contain the true difference of means between the candidate and baseline commits.

CIs of the difference of means are often centered around 0%, because often changes are not that big:

---------------------------------(------|---^--------)-------------------------------->
                              -0.6%    0%  0.3%     +1.2%
                                 |          |        |
         lower bound of the CI --'          |        |
sample mean (center of the CI) -------------'        |
         upper bound of the CI ----------------------'

As described above, a change is considered significant if the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD).

For instance, for an execution time metric, this confidence interval indicates a significantly worse performance:

----------------------------------------|---------|---(---------^---------)---------->
                                       0%        1%  1.3%      2.2%      3.1%
                                                  |   |         |         |
       significant impact threshold --------------'   |         |         |
                      lower bound of CI --------------'         |         |
       sample mean (center of the CI) --------------------------'         |
                      upper bound of CI ----------------------------------'

scenario:httppropagationextract-full_t_id_datadog_headers

  • 🟥 execution_time [+1.679µs; +1.823µs] or [+10.025%; +10.884%]

scenario:httppropagationinject-ids_only

  • 🟥 execution_time [+1.978µs; +2.156µs] or [+11.763%; +12.823%]

scenario:iastaspectsospath-ospathbasename_aspect

  • 🟥 execution_time [+127.694µs; +134.774µs] or [+32.651%; +34.462%]

scenario:iastaspectssplit-rsplit_aspect

  • 🟥 execution_time [+16.032µs; +20.743µs] or [+11.359%; +14.697%]

scenario:samplingrules-high_match

  • 🟥 execution_time [+13.132µs; +15.066µs] or [+8.369%; +9.601%]

scenario:telemetryaddmetric-1-count-metric-1-times

  • 🟥 execution_time [+466.402ns; +505.517ns] or [+16.804%; +18.213%]

scenario:tracer-small

  • 🟥 execution_time [+37.409µs; +40.382µs] or [+11.460%; +12.371%]

Unstable benchmarks

These benchmarks have a confidence interval too wide to call a change; treat them as noise rather than signal.

scenario:coreapiscenario-context_with_data_listeners

  • unstable execution_time [-708.675ns; +761.277ns] or [-6.393%; +6.867%]

scenario:coreapiscenario-core_dispatch_1_listener

  • unstable execution_time [-28.476ns; +37.545ns] or [-4.670%; +6.157%]

scenario:coreapiscenario-core_dispatch_50_listeners

  • unstable execution_time [-1643.850ns; +1632.347ns] or [-9.671%; +9.604%]

scenario:coreapiscenario-core_dispatch_exception_listeners

  • unstable execution_time [-1265.099ns; +1209.300ns] or [-9.707%; +9.279%]

scenario:coreapiscenario-core_dispatch_listeners

  • unstable execution_time [-315.737ns; +335.880ns] or [-8.620%; +9.170%]

scenario:coreapiscenario-core_dispatch_no_args_listeners

  • unstable execution_time [-255.596ns; +256.549ns] or [-8.763%; +8.795%]

scenario:coreapiscenario-core_dispatch_with_results_1_listener

  • unstable execution_time [-59.092ns; +95.445ns] or [-5.141%; +8.304%]

scenario:coreapiscenario-core_dispatch_with_results_50_listeners

  • unstable execution_time [-4010.549ns; +4102.089ns] or [-9.726%; +9.948%]

scenario:coreapiscenario-core_dispatch_with_results_listeners

  • unstable execution_time [-702.206ns; +855.975ns] or [-8.664%; +10.562%]

scenario:packagesupdateimporteddependencies-import_many_stdlib_cached

  • unstable execution_time [-57.402µs; +54.763µs] or [-9.765%; +9.316%]

Known flaky benchmarks

These benchmarks are marked as flaky and will not trigger a failure. Modify FLAKY_BENCHMARKS_REGEX to control which benchmarks are marked as flaky.

scenario:iastaspects-upper_noaspect

  • 🟥 execution_time [+13.442µs; +17.036µs] or [+8.030%; +10.177%]

scenario:span-start

  • 🟥 execution_time [+1.504ms; +1.663ms] or [+10.582%; +11.694%]

Known flaky benchmarks without significant changes:

  • scenario:errortrackingflasksqli-baseline
  • scenario:flasksimple-iast-get
  • scenario:iastaspects-casefold_aspect
  • scenario:iastaspects-casefold_noaspect
  • scenario:iastaspects-index_aspect
  • scenario:iastaspects-ljust_noaspect
  • scenario:iastaspects-lower_aspect
  • scenario:iastaspects-replace_aspect
  • scenario:iastaspects-swapcase_aspect
  • scenario:iastaspects-title_noaspect
  • scenario:iastaspects-translate_aspect
  • scenario:iastaspects-translate_noaspect
  • scenario:packagespackageforrootmodulemapping-cache_off
  • scenario:packagespackageforrootmodulemapping-cache_on
  • scenario:sethttpmeta-all-enabled
  • scenario:telemetryaddmetric-record-100-metrics

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the Riot CI configuration to make Python 3.15 available for opt-in scheduling while keeping the default Riot max version capped at 3.14, and adds the corresponding 3.15 lockfiles for a starter set of suites.

Changes:

  • Add (3, 15) to SUPPORTED_PYTHON_VERSIONS and extend doctests to cover 3.15.
  • Keep the default Riot cap at MAX_PYTHON_VERSION = "3.14" while opting six selected venvs into 3.15 via select_pys(max_version="3.15").
  • Add six new .riot/requirements/*.txt lockfiles generated under Python 3.15 for the newly introduced 3.15 hashes.

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
riotfile.py Adds 3.15 to supported versions, keeps default max at 3.14, and opts specific venvs into 3.15 selection.
.riot/requirements/ee54ec5.txt New Python 3.15 lockfile for one of the newly-added 3.15 venv hashes.
.riot/requirements/c2ce19f.txt New Python 3.15 lockfile for one of the newly-added 3.15 venv hashes (includes setuptools in unsafe section).
.riot/requirements/b388a93.txt New Python 3.15 lockfile for one of the newly-added 3.15 venv hashes.
.riot/requirements/1abe7fb.txt New Python 3.15 lockfile for one of the newly-added 3.15 venv hashes.
.riot/requirements/15d6332.txt New Python 3.15 lockfile for one of the newly-added 3.15 venv hashes.
.riot/requirements/10db676.txt New Python 3.15 lockfile for one of the newly-added 3.15 venv hashes.
Suppressed comments (1)

riotfile.py:71

  • str_to_version() can return variable-length tuples (the doctest includes "3" -> (3,)), but the return type annotation is tuple[int, int]. Updating the return annotation to tuple[int, ...] matches the actual behavior.
    >>> str_to_version("3")
    (3,)

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread riotfile.py
Comment thread riotfile.py
gh-worker-dd-mergequeue-cf854d Bot pushed a commit that referenced this pull request Aug 28, 2026
**prev:** [#19906](#19906) | **next:** [#19910](#19910)

## Summary

Wrapping context + bytecode injection for 3.15. Delta vs #19906 only (monitoring + 3.15 assemblies).

## Test plan

- [ ] CI green on this branch
- [ ] Stack merges cleanly into the next PR's base branch


Co-authored-by: vlad-scherbich <vlad.scherbich@datadoghq.com>
Co-authored-by: gabriele.tornetta <gabriele.tornetta@datadoghq.com>
@vlad-scherbich
vlad-scherbich force-pushed the vlad/py315-riotfile branch 2 times, most recently from f7e0135 to bd4659f Compare August 28, 2026 16:07
@vlad-scherbich vlad-scherbich changed the title ci(riot): schedule Python 3.15 jobs for a starter set ci(riot): schedule Python 3.15 jobs for a starter set (PROF-14439) Aug 28, 2026
@vlad-scherbich
vlad-scherbich marked this pull request as ready for review August 28, 2026 19:44
@vlad-scherbich
vlad-scherbich requested a review from a team as a code owner August 28, 2026 19:44
Base automatically changed from vlad/315-peripheral-compat to main September 4, 2026 15:27
gh-worker-dd-mergequeue-cf854d Bot pushed a commit that referenced this pull request Sep 4, 2026
**prev:** [#19903](#19903) | **next:** [#19906](#19906)

## Description

Delta vs #19903.

`logging.get_version()` returns `""` instead of reading the deprecated `logging.__version__`.

Also drops rST double-backticks in the `patch()` docstring.

Native profiling is not in this PR.

## Testing

<!-- How has the PR been validated?
Please explain how you tested the PR, both on a functional and safety level.
Feel free to include screenshots, DoE results, etc.

Note to agents: if you are generating this PR, do not answer and leave a placeholder instead.
-->

## Risks

<!-- What could go wrong with this PR?

Ask yourself what the risks are, then explain how your are mitigating them.
What is the rollout strategy? What is the rollback strategy?
How are we limiting to a minimum customer exposure to bugs or crashes?

Note to agents: if you are generating this PR, do not answer and leave a placeholder instead.
-->

## Additional Notes

`changelog/no-changelog`.

Contributes to #17817

Co-authored-by: vlad.scherbich <vlad.scherbich@datadoghq.com>
List 3.15 in SUPPORTED_PYTHON_VERSIONS so select_pys can opt in.
Default MAX stays 3.14. Smoke and sourcecode opt in.
Defer the bytecode-only injection assembly import and no-op that unsupported
helper on Python 3.15, allowing sourcecode instrumentation dependencies to
load on the monitoring path. Opt the sourcecode and ddtrace_api suites into
3.15 while keeping the global Python cap at 3.14.
@vlad-scherbich

Copy link
Copy Markdown
Contributor Author

/code blockers

@gh-worker-devflow-routing-ef8351

gh-worker-devflow-routing-ef8351 Bot commented Sep 4, 2026

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2026-09-04 17:42:47 UTC ℹ️ Start processing command /code blockers


2026-09-04 17:42:48 UTC ℹ️ Devflow:

Checking merge blockers for #19906...


2026-09-04 17:42:49 UTC ℹ️ Devflow: /code blockers

Detected 5 merge blocker(s) to address:

🔴 Blocking

  • Missing approvals from code owners
    Required teams: ci-app-libraries
    Hint: Obtain approval from the listed reviewer(s) or owning team(s).
  • Required check system-tests finished has not reported
    Hint: Ensure the workflow that produces this check is triggered.

🟠 Pending

@vlad-scherbich

Copy link
Copy Markdown
Contributor Author

/code blockers

@gh-worker-devflow-routing-ef8351

gh-worker-devflow-routing-ef8351 Bot commented Sep 4, 2026

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2026-09-04 17:54:52 UTC ℹ️ Start processing command /code blockers


2026-09-04 17:54:53 UTC ℹ️ Devflow:

Checking merge blockers for #19906...


2026-09-04 17:55:04 UTC ℹ️ Devflow: /code blockers

Detected 4 merge blocker(s) to address:

🔴 Blocking

  • Missing approvals from code owners
    Required teams: ci-app-libraries
    Hint: Obtain approval from the listed reviewer(s) or owning team(s).
  • Required check system-tests finished has not reported
    Hint: Ensure the workflow that produces this check is triggered.

🟠 Pending

@vlad-scherbich

Copy link
Copy Markdown
Contributor Author

/code blockers

@gh-worker-devflow-routing-ef8351

gh-worker-devflow-routing-ef8351 Bot commented Sep 4, 2026

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2026-09-04 18:01:42 UTC ℹ️ Start processing command /code blockers


2026-09-04 18:01:43 UTC ℹ️ Devflow:

Checking merge blockers for #19906...


2026-09-04 18:01:43 UTC ℹ️ Devflow: /code blockers

Detected 4 merge blocker(s) to address:

🔴 Blocking

  • Required check dd-gitlab/default-pipeline has not reported
    Hint: Ensure the workflow that produces this check is triggered.
  • Required check system-tests finished has not reported
    Hint: Ensure the workflow that produces this check is triggered.

🟠 Pending

@vlad-scherbich vlad-scherbich changed the title ci(riot): schedule Python 3.15 jobs for a starter set (PROF-14439) ci(riot): schedule Python 3.15 jobs for our smoke-test (PROF-14439) Sep 4, 2026
@vlad-scherbich vlad-scherbich changed the title ci(riot): schedule Python 3.15 jobs for our smoke-test (PROF-14439) ci(riot): schedule Python 3.15 jobs for 'tests/smoke_test.py ' (PROF-14439) Sep 4, 2026
@vlad-scherbich vlad-scherbich changed the title ci(riot): schedule Python 3.15 jobs for 'tests/smoke_test.py ' (PROF-14439) ci(riot): schedule Python 3.15 jobs for 'smoke_test.py ' (PROF-14439) Sep 4, 2026
@vlad-scherbich

Copy link
Copy Markdown
Contributor Author

/code blockers

@gh-worker-devflow-routing-ef8351

gh-worker-devflow-routing-ef8351 Bot commented Sep 4, 2026

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2026-09-04 19:21:07 UTC ℹ️ Start processing command /code blockers


2026-09-04 19:21:08 UTC ℹ️ Devflow:

Checking merge blockers for #19906...


2026-09-04 19:21:22 UTC ℹ️ Devflow: /code blockers

Detected 2 merge blocker(s) to address:

🔴 Blocking

  • Required check system-tests finished has not reported
    Hint: Ensure the workflow that produces this check is triggered.

🟠 Pending

@gh-worker-dd-mergequeue-cf854d
gh-worker-dd-mergequeue-cf854d Bot merged commit 7692bdc into main Sep 4, 2026
1527 of 1529 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/no-changelog A changelog entry is not required for this PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants