Skip to content

ci(build_base_venvs): let riot install the dev package on Python 3.15 (PROF-14439) - #19904

Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 1 commit into
mainfrom
vlad/py315-riot-install
Sep 2, 2026
Merged

ci(build_base_venvs): let riot install the dev package on Python 3.15 (PROF-14439)#19904
gh-worker-dd-mergequeue-cf854d[bot] merged 1 commit into
mainfrom
vlad/py315-riot-install

Conversation

@vlad-scherbich

@vlad-scherbich vlad-scherbich commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

Description

Delta vs #19907.

riot's install_dev_pkg runs pip install -e ., so pip enforces requires-python = ">=3.9,<3.15" and refuses the dev package on 3.15. This PR sets PIP_IGNORE_REQUIRES_PYTHON=1 only for the PYTHON_VERSION=3.15 arm of build_base_venvs. Published metadata stays <3.15.

Testing

Inspect the generated build_base_venvs before_script for PYTHON_VERSION=3.15 and confirm the ignore is set only on that arm.

Risks

None. 3.15-only env var; other matrix versions unchanged.

Additional Notes

No release note: CI chore, changelog/no-changelog. Base: #19907. Next: #19906.

@datadog-official

datadog-official Bot commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

Tests

🎉 All green!

🧪 All tests passed
❄️ No new flaky tests detected

🔄 Datadog retried 10 tests - 8 passed on retry View in Datadog

🚧 19 tests that failed were ignored due to quarantine View in Datadog

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 24f53a0 | Docs | View more details | Give us feedback!

@pr-commenter

pr-commenter Bot commented Aug 27, 2026

Copy link
Copy Markdown

Benchmarks

Benchmark execution time: 2026-09-02 02:48:04

Comparing candidate commit 24f53a0 in PR branch vlad/py315-riot-install with baseline commit a78b774 in branch main.

📊 Benchmarking dashboard

Found 0 performance improvements and 6 performance regressions! Performance is the same for 576 metrics, 10 unstable metrics, 1 known flaky benchmarks, 17 flaky benchmarks without significant changes.

Explanation

This is an A/B test comparing a candidate commit's performance against that of a baseline commit. Performance changes are noted in the tables below as:

  • 🟩 = significantly better candidate vs. baseline
  • 🟥 = significantly worse candidate vs. baseline

We compute a confidence interval (CI) over the relative difference of means between metrics from the candidate and baseline commits, considering the baseline as the reference.

If the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD), the change is considered significant.

Feel free to reach out to #apm-benchmarking-platform on Slack if you have any questions.

More details about the CI and significant changes

You can imagine this CI as a range of values that is likely to contain the true difference of means between the candidate and baseline commits.

CIs of the difference of means are often centered around 0%, because often changes are not that big:

---------------------------------(------|---^--------)-------------------------------->
                              -0.6%    0%  0.3%     +1.2%
                                 |          |        |
         lower bound of the CI --'          |        |
sample mean (center of the CI) -------------'        |
         upper bound of the CI ----------------------'

As described above, a change is considered significant if the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD).

For instance, for an execution time metric, this confidence interval indicates a significantly worse performance:

----------------------------------------|---------|---(---------^---------)---------->
                                       0%        1%  1.3%      2.2%      3.1%
                                                  |   |         |         |
       significant impact threshold --------------'   |         |         |
                      lower bound of CI --------------'         |         |
       sample mean (center of the CI) --------------------------'         |
                      upper bound of CI ----------------------------------'

scenario:httppropagationinject-ids_only

  • 🟥 execution_time [+1.791µs; +1.906µs] or [+10.757%; +11.446%]

scenario:iastaspects-rstrip_aspect

  • 🟥 execution_time [+70.607µs; +76.212µs] or [+18.506%; +19.975%]

scenario:iastaspects-stringio_noaspect

  • 🟥 execution_time [+25.871µs; +29.832µs] or [+7.842%; +9.043%]

scenario:iastaspectsospath-ospathbasename_aspect

  • 🟥 execution_time [+114.218µs; +120.640µs] or [+28.748%; +30.364%]

scenario:telemetryaddmetric-1-count-metric-1-times

  • 🟥 execution_time [+395.765ns; +439.066ns] or [+14.809%; +16.429%]

scenario:tracer-small

  • 🟥 execution_time [+38.100µs; +40.244µs] or [+11.375%; +12.015%]

Unstable benchmarks

These benchmarks have a confidence interval too wide to call a change; treat them as noise rather than signal.

scenario:coreapiscenario-context_with_data_listeners

  • unstable execution_time [-671.167ns; +815.542ns] or [-6.087%; +7.396%]

scenario:coreapiscenario-core_dispatch_1_listener

  • unstable execution_time [-33.430ns; +35.455ns] or [-5.367%; +5.692%]

scenario:coreapiscenario-core_dispatch_50_listeners

  • unstable execution_time [-1710.424ns; +1622.918ns] or [-9.915%; +9.407%]

scenario:coreapiscenario-core_dispatch_exception_listeners

  • unstable execution_time [-1243.464ns; +1208.191ns] or [-9.633%; +9.359%]

scenario:coreapiscenario-core_dispatch_listeners

  • unstable execution_time [-324.459ns; +334.972ns] or [-8.730%; +9.013%]

scenario:coreapiscenario-core_dispatch_no_args_listeners

  • unstable execution_time [-257.149ns; +259.503ns] or [-8.714%; +8.793%]

scenario:coreapiscenario-core_dispatch_with_results_1_listener

  • unstable execution_time [-77.964ns; +72.120ns] or [-6.616%; +6.120%]

scenario:coreapiscenario-core_dispatch_with_results_50_listeners

  • unstable execution_time [-4193.431ns; +3765.680ns] or [-10.224%; +9.181%]

scenario:coreapiscenario-core_dispatch_with_results_listeners

  • unstable execution_time [-797.475ns; +747.997ns] or [-9.834%; +9.224%]

scenario:packagesupdateimporteddependencies-import_many_stdlib_cached

  • unstable execution_time [-40885.535ns; +42667.801ns] or [-6.506%; +6.790%]

Known flaky benchmarks

These benchmarks are marked as flaky and will not trigger a failure. Modify FLAKY_BENCHMARKS_REGEX to control which benchmarks are marked as flaky.

scenario:span-start

  • 🟥 execution_time [+1.783ms; +2.052ms] or [+13.205%; +15.195%]

Known flaky benchmarks without significant changes:

  • scenario:errortrackingflasksqli-baseline
  • scenario:flasksimple-iast-get
  • scenario:iastaspects-casefold_aspect
  • scenario:iastaspects-casefold_noaspect
  • scenario:iastaspects-index_aspect
  • scenario:iastaspects-ljust_noaspect
  • scenario:iastaspects-lower_aspect
  • scenario:iastaspects-replace_aspect
  • scenario:iastaspects-swapcase_aspect
  • scenario:iastaspects-title_noaspect
  • scenario:iastaspects-translate_aspect
  • scenario:iastaspects-translate_noaspect
  • scenario:iastaspects-upper_noaspect
  • scenario:packagespackageforrootmodulemapping-cache_off
  • scenario:packagespackageforrootmodulemapping-cache_on
  • scenario:sethttpmeta-all-enabled
  • scenario:telemetryaddmetric-record-100-metrics

@vlad-scherbich
vlad-scherbich force-pushed the vlad/py315-riot-install branch from 4d1c0d3 to d76a38e Compare August 27, 2026 21:11
vlad-scherbich added a commit that referenced this pull request Aug 27, 2026
Add (3, 15) to SUPPORTED_PYTHON_VERSIONS and opt in six venvs. Default
max stays 3.14 so uncapped suites do not mix 3.15 into 3.9-3.14 jobs.
requires-python is unchanged; 3.15 installs fail until #19904.
@vlad-scherbich
vlad-scherbich changed the base branch from main to vlad/py315-testrunner-cython-pin August 27, 2026 21:11
@cit-pr-commenter-54b7da

cit-pr-commenter-54b7da Bot commented Aug 27, 2026

Copy link
Copy Markdown

Codeowners resolved as

Resolved from the full PR diff against main using the target branch CODEOWNERS file.
CODEOWNERS team requests not listed below are not required by the current file set.

No remaining files require a CODEOWNERS review.

@cit-pr-commenter-54b7da

Copy link
Copy Markdown

Circular import analysis

⚠️ Existing circular imports

There are 3 circular imports that already exist on the base branch and have not been changed by this PR.

ddtrace.llmobs -> ddtrace.llmobs._evaluators -> ddtrace.llmobs._evaluators.format -> ddtrace.llmobs._experiment -> ddtrace.llmobs
ddtrace.errortracking._handled_exceptions.bytecode_injector -> ddtrace.errortracking._handled_exceptions.callbacks -> ddtrace.errortracking._handled_exceptions.collector -> ddtrace.errortracking._handled_exceptions.bytecode_reporting -> ddtrace.errortracking._handled_exceptions.bytecode_injector
ddtrace.appsec._asm_request_context -> ddtrace.appsec._iast._iast_request_context_base -> ddtrace.appsec._iast._iast_env -> ddtrace.appsec._iast.reporter -> ddtrace.appsec._exploit_prevention.stack_traces -> ddtrace.appsec._asm_request_context

1 similar comment
@cit-pr-commenter-54b7da

Copy link
Copy Markdown

Circular import analysis

⚠️ Existing circular imports

There are 3 circular imports that already exist on the base branch and have not been changed by this PR.

ddtrace.llmobs -> ddtrace.llmobs._evaluators -> ddtrace.llmobs._evaluators.format -> ddtrace.llmobs._experiment -> ddtrace.llmobs
ddtrace.errortracking._handled_exceptions.bytecode_injector -> ddtrace.errortracking._handled_exceptions.callbacks -> ddtrace.errortracking._handled_exceptions.collector -> ddtrace.errortracking._handled_exceptions.bytecode_reporting -> ddtrace.errortracking._handled_exceptions.bytecode_injector
ddtrace.appsec._asm_request_context -> ddtrace.appsec._iast._iast_request_context_base -> ddtrace.appsec._iast._iast_env -> ddtrace.appsec._iast.reporter -> ddtrace.appsec._exploit_prevention.stack_traces -> ddtrace.appsec._asm_request_context

@cit-pr-commenter-54b7da

cit-pr-commenter-54b7da Bot commented Aug 27, 2026

Copy link
Copy Markdown

Dependency direction analysis

⚠️ Existing dependency direction violations

There are 240 dependency direction violations that already exist on the base branch and have not been changed by this PR.

Show existing violations (showing 5 of 240 highest severity)
ddtrace.internal.tracemethods -×-> ddtrace.trace  (internal-core -> product:tracing, score=135)
ddtrace.llmobs._integrations.langgraph -×-> ddtrace.trace  (product:llmobs -> product:tracing, score=133)
ddtrace.internal.opentelemetry.trace -×-> ddtrace.trace  (product:opentelemetry -> product:tracing, score=133)
ddtrace.llmobs._integrations.langchain -×-> ddtrace.trace  (product:llmobs -> product:tracing, score=133)
ddtrace.debugging._signal.model -×-> ddtrace.trace  (product:debugging -> product:tracing, score=133)

To see all violations, download the layers-base.json and layers-pr.json artifacts from this CI job and run:

uv run --script scripts/import-analysis/layers.py compare layers-base.json layers-pr.json

@cit-pr-commenter-54b7da

cit-pr-commenter-54b7da Bot commented Aug 27, 2026

Copy link
Copy Markdown

Circular import analysis

⚠️ Existing circular imports

There are 3 circular imports that already exist on the base branch and have not been changed by this PR.

ddtrace.errortracking._handled_exceptions.bytecode_injector -> ddtrace.errortracking._handled_exceptions.callbacks -> ddtrace.errortracking._handled_exceptions.collector -> ddtrace.errortracking._handled_exceptions.bytecode_reporting -> ddtrace.errortracking._handled_exceptions.bytecode_injector
ddtrace.llmobs -> ddtrace.llmobs._evaluators -> ddtrace.llmobs._evaluators.format -> ddtrace.llmobs._experiment -> ddtrace.llmobs
ddtrace.appsec._asm_request_context -> ddtrace.appsec._iast._iast_request_context_base -> ddtrace.appsec._iast._iast_env -> ddtrace.appsec._iast.reporter -> ddtrace.appsec._exploit_prevention.stack_traces -> ddtrace.appsec._asm_request_context

@cit-pr-commenter-54b7da

cit-pr-commenter-54b7da Bot commented Aug 27, 2026

Copy link
Copy Markdown

Dependency direction analysis

⚠️ Existing dependency direction violations

There are 230 dependency direction violations that already exist on the base branch and have not been changed by this PR.

Show existing violations (showing 5 of 230 highest severity)
ddtrace.internal.tracemethods -×-> ddtrace.trace  (internal-core -> product:tracing, score=134)
ddtrace.llmobs._integrations.llama_index -×-> ddtrace.trace  (product:llmobs -> product:tracing, score=132)
ddtrace.llmobs._integrations.base -×-> ddtrace.trace  (product:llmobs -> product:tracing, score=132)
ddtrace.llmobs._integrations.claude_agent_sdk -×-> ddtrace.trace  (product:llmobs -> product:tracing, score=132)
ddtrace.debugging._signal.model -×-> ddtrace.trace  (product:debugging -> product:tracing, score=132)

To see all violations, download the layers-base.json and layers-pr.json artifacts from this CI job and run:

uv run --script scripts/import-analysis/layers.py compare layers-base.json layers-pr.json

@vlad-scherbich vlad-scherbich changed the title ci(build_base_venvs): let riot install the dev package on Python 3.15 ci(build_base_venvs): let riot install the dev package on Python 3.15 (PROF-14439) Aug 27, 2026
@vlad-scherbich vlad-scherbich added the changelog/no-changelog A changelog entry is not required for this PR. label Aug 27, 2026
@vlad-scherbich
vlad-scherbich marked this pull request as ready for review August 27, 2026 22:59
@vlad-scherbich
vlad-scherbich requested review from a team as code owners August 27, 2026 22:59
@vlad-scherbich
vlad-scherbich requested review from Yun-Kim and juanjux and removed request for a team August 27, 2026 22:59
vlad-scherbich added a commit that referenced this pull request Aug 27, 2026
Add (3, 15) to SUPPORTED_PYTHON_VERSIONS and opt in six venvs. Default
max stays 3.14 so uncapped suites do not mix 3.15 into 3.9-3.14 jobs.
requires-python is unchanged; 3.15 installs fail until #19904.
@vlad-scherbich
vlad-scherbich force-pushed the vlad/py315-testrunner-cython-pin branch from 992d101 to d872a18 Compare August 28, 2026 14:08
@vlad-scherbich
vlad-scherbich force-pushed the vlad/py315-riot-install branch from faa10e0 to ff3b31d Compare August 28, 2026 14:08
vlad-scherbich added a commit that referenced this pull request Aug 28, 2026
Add (3, 15) to SUPPORTED_PYTHON_VERSIONS and opt in six venvs. Default
max stays 3.14 so uncapped suites do not mix 3.15 into 3.9-3.14 jobs.
requires-python is unchanged; 3.15 installs fail until #19904.
@vlad-scherbich
vlad-scherbich force-pushed the vlad/py315-testrunner-cython-pin branch from d872a18 to 8b2e454 Compare August 28, 2026 14:57
@vlad-scherbich
vlad-scherbich force-pushed the vlad/py315-riot-install branch from ff3b31d to 1d86b3f Compare August 28, 2026 14:57
vlad-scherbich added a commit that referenced this pull request Aug 28, 2026
Add (3, 15) to SUPPORTED_PYTHON_VERSIONS and opt in six venvs. Default
max stays 3.14 so uncapped suites do not mix 3.15 into 3.9-3.14 jobs.
requires-python is unchanged; 3.15 installs fail until #19904.
@vlad-scherbich
vlad-scherbich force-pushed the vlad/py315-testrunner-cython-pin branch from 8b2e454 to 5785062 Compare August 28, 2026 15:51
@vlad-scherbich
vlad-scherbich force-pushed the vlad/py315-riot-install branch from 1d86b3f to 32c9f29 Compare August 28, 2026 15:51
vlad-scherbich added a commit that referenced this pull request Aug 28, 2026
Add (3, 15) to SUPPORTED_PYTHON_VERSIONS and opt in six venvs. Default
max stays 3.14 so uncapped suites do not mix 3.15 into 3.9-3.14 jobs.
requires-python is unchanged; 3.15 installs fail until #19904.
@vlad-scherbich
vlad-scherbich force-pushed the vlad/py315-testrunner-cython-pin branch from 5785062 to 7e222d3 Compare August 28, 2026 16:07
@vlad-scherbich
vlad-scherbich force-pushed the vlad/py315-riot-install branch from 32c9f29 to 801e339 Compare August 28, 2026 16:07
@vlad-scherbich
vlad-scherbich force-pushed the vlad/py315-testrunner-cython-pin branch from 7e222d3 to 639f7b7 Compare August 28, 2026 18:34
@vlad-scherbich
vlad-scherbich requested a review from a team as a code owner August 28, 2026 18:34
@vlad-scherbich
vlad-scherbich force-pushed the vlad/py315-riot-install branch from 801e339 to 19654b8 Compare August 28, 2026 18:34
vlad-scherbich added a commit that referenced this pull request Aug 28, 2026
Add (3, 15) to SUPPORTED_PYTHON_VERSIONS and opt in six venvs. Default
max stays 3.14 so uncapped suites do not mix 3.15 into 3.9-3.14 jobs.
requires-python is unchanged; 3.15 installs fail until #19904.
vlad-scherbich added a commit that referenced this pull request Aug 28, 2026
#17849 wrapping is merging to main; hashes sharing jobs and pip
install -e . (#19904) are the remaining reasons MAX stays 3.14.
vlad-scherbich added a commit that referenced this pull request Aug 30, 2026
#17849 wrapping is merging to main; hashes sharing jobs and pip
install -e . (#19904) are the remaining reasons MAX stays 3.14.

(cherry picked from commit 117a724)
vlad-scherbich added a commit that referenced this pull request Aug 30, 2026
#17849 wrapping is merging to main; hashes sharing jobs and pip
install -e . (#19904) are the remaining reasons MAX stays 3.14.

(cherry picked from commit 117a724)
(cherry picked from commit 6b123dc)
vlad-scherbich added a commit that referenced this pull request Aug 30, 2026
#17849 wrapping is merging to main; hashes sharing jobs and pip
install -e . (#19904) are the remaining reasons MAX stays 3.14.

(cherry picked from commit 117a724)
(cherry picked from commit 6b123dc)
(cherry picked from commit 9003388)
@vlad-scherbich
vlad-scherbich requested a review from a team as a code owner August 30, 2026 18:26
@vlad-scherbich
vlad-scherbich force-pushed the vlad/py315-testrunner-cython-pin branch from afd0994 to 60de544 Compare August 31, 2026 18:30
@vlad-scherbich
vlad-scherbich force-pushed the vlad/py315-riot-install branch from 530a2f5 to 680d8a6 Compare August 31, 2026 18:31
@vlad-scherbich
vlad-scherbich force-pushed the vlad/py315-testrunner-cython-pin branch from 60de544 to 601e853 Compare September 1, 2026 02:31
@vlad-scherbich
vlad-scherbich force-pushed the vlad/py315-riot-install branch from 680d8a6 to 8491e07 Compare September 1, 2026 02:32
@vlad-scherbich
vlad-scherbich force-pushed the vlad/py315-testrunner-cython-pin branch from 61d15e1 to a77787f Compare September 2, 2026 01:52
@vlad-scherbich
vlad-scherbich force-pushed the vlad/py315-riot-install branch from 8491e07 to c224d64 Compare September 2, 2026 01:52
PIP_IGNORE_REQUIRES_PYTHON lets riot pip-install the editable package despite
requires-python excluding 3.15. 3.15 only.
TODO(py-315): drop this once requires-python includes 3.15.
@vlad-scherbich
vlad-scherbich changed the base branch from vlad/py315-testrunner-cython-pin to main September 2, 2026 02:19
@vlad-scherbich
vlad-scherbich force-pushed the vlad/py315-riot-install branch from c224d64 to 24f53a0 Compare September 2, 2026 02:20
@vlad-scherbich

Copy link
Copy Markdown
Contributor Author

/merge -m squash

@gh-worker-devflow-routing-ef8351

gh-worker-devflow-routing-ef8351 Bot commented Sep 2, 2026

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2026-09-02 03:01:30 UTC ℹ️ Start processing command /merge -m squash


2026-09-02 03:01:35 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in main is approximately 1h (p90).


2026-09-02 03:41:56 UTC ℹ️ MergeQueue: This merge request was merged

gh-worker-dd-mergequeue-cf854d Bot pushed a commit that referenced this pull request Sep 2, 2026
… (PROF-14439) (#19907)

## Description

Delta vs #19903.

`docker/Dockerfile`: pyenv `v2.6.31` → `v2.8.4`. A `docker/**` push to `main` retriggers `.github/workflows/testrunner.yml` and recompiles `3.15-dev`. Does not pin a 3.15.0 interpreter or the GitLab `TESTRUNNER_IMAGE` digest.

`.cached_testrunner` EXT_CACHE_VENV: `pip install … 'Cython<3.3'` when `PYTHON_VERSION=3.15`; other versions stay unpinned `Cython`.

If this merges and nothing else new lands: the next testrunner image rebuilds with pyenv 2.8.4, and the 3.15 cache venv gets Cython 3.2.x. GitLab jobs keep the old digest until a follow-up pins it.

## Testing

Image rebuild is the testrunner workflow after merge to `main`. After publish, pin `.gitlab/testrunner.yml`. Confirm the generated 3.15 `build_base_venvs` `before_script` installs `Cython<3.3`.

## Risks

Pyenv 2.8.4 also reinstalls 3.8–3.14 (patch-level bumps possible). Cython pin is 3.15-only.

## Additional Notes

Does not duplicate #19861 (`pyproject.toml` unchanged). No release note: CI chore, `changelog/no-changelog`.

Base: #19903. Next: #19904.


Co-authored-by: vlad.scherbich <vlad.scherbich@datadoghq.com>
@gh-worker-dd-mergequeue-cf854d
gh-worker-dd-mergequeue-cf854d Bot merged commit ccb6e17 into main Sep 2, 2026
1236 checks passed
@gh-worker-dd-mergequeue-cf854d
gh-worker-dd-mergequeue-cf854d Bot deleted the vlad/py315-riot-install branch September 2, 2026 03:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/no-changelog A changelog entry is not required for this PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants