Fix role creation leaving new roles with zero permissions

app/Console/Commands/ImportSqlDump.php

@@ -311,7 +311,7 @@ private function runLegacyToNewMapping(string $connection, string $legacyDb, str
             'aslab' => array_merge(PermissionGroupEnum::ASLAB, ['manage-pelanggaran']),
             'atc' => PermissionGroupEnum::ATC,
             'rdc' => PermissionGroupEnum::RDC,
-            'asisten' => array_values(array_diff(PermissionGroupEnum::ASISTEN, [PermissionGroupEnum::SEE_MODUL])),
+            'asisten' => PermissionGroupEnum::ASISTEN,
             'praktikan' => PermissionGroupEnum::PRAKTIKAN,
         ];
 

app/Http/Controllers/API/RoleController.php

@@ -71,12 +71,12 @@ public function store(Request $request)
                 }
 
                 switch ($paket) {
-                    // case 'super':
-                    //     $permissions = array_merge($permissions, $SUPER_PACKAGE);
-                    //     break;
-                    // case 'aslab':
-                    //     $permissions = array_merge($permissions, $ASLAB_PACKAGE);
-                    //     break;
+                    case 'super':
+                        $permissions = array_merge($permissions, $SUPER_PACKAGE);
+                        break;
+                    case 'aslab':
+                        $permissions = array_merge($permissions, $ASLAB_PACKAGE);
+                        break;
                     case 'atc':
                         $permissions = array_merge($permissions, $ATC_PACKAGE);
                         break;
@@ -92,13 +92,18 @@ public function store(Request $request)
                 }
             }
 
+            // Every asisten role needs manage-profile to land on /assistant after login,
+            // regardless of which packages were selected (mirrors RolePermissionsSeeder,
+            // where every seeded role has it).
+            $permissions[] = PermissionGroupEnum::MANAGE_PROFILE;
+
             $role = Role::create([
                 'name' => $request->name,
                 'guard_name' => 'asisten',
                 'created_at' => now(),
                 'updated_at' => now(),
             ]);
-            $role->syncPermissions($permissions);
+            $role->syncPermissions(array_unique($permissions));
 
             return redirect(route('manage-role'))->with('success', 'Role created successfully.');
         } catch (\Throwable $th) {

app/PermissionGroupEnum.php

@@ -14,8 +14,6 @@ enum PermissionGroupEnum: string
 
     const MANAGE_MODUL = 'manage-modul';
 
-    const SEE_MODUL = 'see-modul';
-
     const MANAGE_SOAL = 'manage-soal';
 
     const UNLOCK_JAWABAN = 'unlock-jawaban';
@@ -100,7 +98,6 @@ enum PermissionGroupEnum: string
         self::MANAGE_PROFILE,
         self::SEE_PRAKTIKUM,
         self::SEE_HISTORY,
-        self::SEE_MODUL,
         self::SEE_SOAL,
         self::NILAI_PRAKTIKAN,
         self::SEE_PLOT,

resources/js/bootstrap.js

@@ -7,25 +7,29 @@ window.axios.defaults.headers.common['X-Requested-With'] = 'XMLHttpRequest';
 
 window.Pusher = Pusher;
 
-window.Echo = new Echo({
-  broadcaster: 'reverb',
-  key: import.meta.env.VITE_REVERB_APP_KEY,
-  wsHost: import.meta.env.VITE_REVERB_HOST,
-  wsPort: import.meta.env.VITE_REVERB_PORT ?? 80,
-  wssPort: import.meta.env.VITE_REVERB_PORT ?? 443,
-  forceTLS: (import.meta.env.VITE_REVERB_SCHEME ?? 'https') === 'https',
-  enabledTransports: ['ws'],
-  authEndpoint: '/broadcasting/auth',
-  auth: {
-    headers: {
-      'X-CSRF-TOKEN': document.querySelector('meta[name="csrf-token"]')?.getAttribute('content'),
-    },
-  },
-});
 /**
  * Echo exposes an expressive API for subscribing to channels and listening
  * for events that are broadcast by Laravel. Echo and event broadcasting
  * allow your team to quickly build robust real-time web applications.
+ *
+ * Only connect when a Reverb key is configured (VITE_REVERB_APP_KEY) so local
+ * dev without a running Reverb server doesn't spam failed websocket retries.
+ * Consumers already guard on `window.Echo` being truthy before using it.
  */
-
-import './echo';
+if (import.meta.env.VITE_REVERB_APP_KEY) {
+  window.Echo = new Echo({
+    broadcaster: 'reverb',
+    key: import.meta.env.VITE_REVERB_APP_KEY,
+    wsHost: import.meta.env.VITE_REVERB_HOST,
+    wsPort: import.meta.env.VITE_REVERB_PORT ?? 80,
+    wssPort: import.meta.env.VITE_REVERB_PORT ?? 443,
+    forceTLS: (import.meta.env.VITE_REVERB_SCHEME ?? 'https') === 'https',
+    enabledTransports: ['ws'],
+    authEndpoint: '/broadcasting/auth',
+    auth: {
+      headers: {
+        'X-CSRF-TOKEN': document.querySelector('meta[name="csrf-token"]')?.getAttribute('content'),
+      },
+    },
+  });
+}