Fix role creation leaving new roles with zero permissions - #18
Open
ShowMeMyCent wants to merge 1 commit into
Open
Fix role creation leaving new roles with zero permissions#18ShowMeMyCent wants to merge 1 commit into
ShowMeMyCent wants to merge 1 commit into
Conversation
RoleController::store had three stacked bugs that combined to make role creation silently non-functional: - The 'super' and 'aslab' package cases were commented out in the switch statement, falling through to a default branch that reset the whole permissions accumulator to empty. - No package guaranteed manage-profile/lms-configuration, the only permissions accepted by the /assistant route every asisten lands on after login, so roles without asisten or aslab checked could log in but were immediately blocked. - PermissionGroupEnum::ASISTEN (the default, pre-checked package) referenced see-modul, a permission never seeded into the database and checked by no route. syncPermissions() throws on unresolvable names before writing anything, so any role including the default package ended up with zero permissions regardless of the fixes above. Removed the dead see-modul entry; ImportSqlDump.php already worked around this same bug locally, so simplified it to match. Also gate Reverb/Echo initialization on VITE_REVERB_APP_KEY being configured, since local dev without a running Reverb server was spamming failed websocket reconnect attempts. Removed echo.js, a dead duplicate of the same unconditional Echo instantiation. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
ShowMeMyCent
requested review from
Alizaaaja4,
IritaSee,
Soedipo,
adhiiimf,
fakhrip,
marzkigun27 and
vincentiusantu
August 14, 2026 11:02
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RoleController::store had three stacked bugs that combined to make role creation silently non-functional:
Also gate Reverb/Echo initialization on VITE_REVERB_APP_KEY being configured, since local dev without a running Reverb server was spamming failed websocket reconnect attempts. Removed echo.js, a dead duplicate of the same unconditional Echo instantiation.