Mid-point review cleanup: iPhone-only declaration, dead weight, stale comments - #134
Merged
Conversation
…comments - TARGETED_DEVICE_FAMILY "1" (owner 2026-07-23): iPad is not in scope; XcodeGen's default silently opted us into iPad review + screenshots. - Retire launch-splash.imageset (storyboard launch screen device-confirmed; the asset's own comment said to remove it). - Remove DailiesGlyph/DailiesGlyphShape (unused since Important moved to ImportantGlyph, owner 2026-07-06). - Remove scrollToTakeID (write-only since the UIKit timeline replaced the ScrollViewReader at M7; the editor now keyboard-anchors instead) and its stale load-bearing comments. - Fix stale comments: NewObieIntent IS shared into the widget extension; Quadrant.important Night doc-comment now cites the confirmed #E0D9CE. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Considus
added a commit
that referenced
this pull request
Jul 26, 2026
PR #134 set TARGETED_DEVICE_FAMILY: "1" in settings.base, which XcodeGen writes at PBXProject level. XcodeGen also writes its own "1,2" into every target, and target level beats project level in Xcode — so all four targets, including the app, still declared iPad support. The lock has been inert since 2026-07-23: a submission today would still have drawn iPad App Review and iPad screenshot requirements, the exact thing D-134 was written to avoid. Repeat the setting in each target's own settings.base. Verified against the regenerated pbxproj: all four targets and the project now read 1. D-139.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Owner-approved cleanup items from the 2026-07-23 mid-point code review:
TARGETED_DEVICE_FAMILY: "1"— iPad was never in scope; XcodeGen's default ("1,2") silently opted us into iPad App Review runs and iPad screenshot requirements.launch-splash.imageset(storyboard launch is device-confirmed; the comment said to remove it) and the unusedDailiesGlyph/DailiesGlyphShape.scrollToTakeID— write-only since the UIKit timeline replaced the ScrollViewReader at M7; its comments still claimed it was load-bearing.NewObieIntentIS shared into the widget extension (Controls fire it);Quadrant.importantdoc-comment now cites the confirmed Stone#E0D9CE.No behaviour change intended anywhere in this PR.
Tests
🤖 Generated with Claude Code