Make the iPhone-only device target actually take effect (D-139) - #142
Merged
Conversation
PR #134 set TARGETED_DEVICE_FAMILY: "1" in settings.base, which XcodeGen writes at PBXProject level. XcodeGen also writes its own "1,2" into every target, and target level beats project level in Xcode — so all four targets, including the app, still declared iPad support. The lock has been inert since 2026-07-23: a submission today would still have drawn iPad App Review and iPad screenshot requirements, the exact thing D-134 was written to avoid. Repeat the setting in each target's own settings.base. Verified against the regenerated pbxproj: all four targets and the project now read 1. D-139.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
TARGETED_DEVICE_FAMILY: "1"was set only insettings.base, which XcodeGen writes at PBXProject level. XcodeGen independently writes"1,2"into every target, and target level beats project level in Xcode.Verified against the generated pbxproj before this change:
<PROJECT>111,21,21,21,21,21,2So the iPhone-only decision from PR #134 (2026-07-23) has been inert since it landed. Submitting today would still have triggered iPad App Review and iPad screenshot requirements.
Change
Repeat
TARGETED_DEVICE_FAMILY: "1"in each of the four targets' ownsettings.base, and note insettings.basewhy the project-level value is not sufficient on its own.Verification
xcodegen generate, then parse the pbxproj and assert everyXCBuildConfigurationreachable from the project and from each native target:UISupportedInterfaceOrientations~ipadis left inInfo.plist— now inert, and out of scope here.Found by the nightly audit, 2026-07-26. Recorded as D-139.
🤖 Generated with Claude Code