Skip to content

test: record mobile visual viewport scale policy - #2752

Merged
Chris0Jeky merged 1 commit into
mainfrom
issue-1867/zoom-observation
Sep 6, 2026
Merged

test: record mobile visual viewport scale policy#2752
Chris0Jeky merged 1 commit into
mainfrom
issue-1867/zoom-observation

Conversation

@Chris0Jeky

Copy link
Copy Markdown
Owner

Summary

  • extend the existing synthetic mobile VisualViewport harness with scale
  • assert a scale-only change preserves the existing keyboard-contracted modal geometry
  • keep native pinch transforms and physical-device reachability explicitly outside synthetic CI evidence

Verification

  • npx playwright test tests/e2e/mobile-responsive.spec.ts --project=mobile-chrome --grep "card editing modal follows" --reporter=line — 1 passed
  • npx playwright test tests/e2e/mobile-responsive.spec.ts --project=mobile-chrome --reporter=line — 7 passed
  • npm run typecheck — passed
  • npm run build — passed
  • npx eslint tests/e2e/mobile-responsive.spec.ts — passed
  • git diff --check — passed

Refs #1867

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, add credits to your account and enable them for code reviews in your settings.

@Chris0Jeky
Chris0Jeky merged commit 7a44a11 into main Sep 6, 2026
35 checks passed
@Chris0Jeky
Chris0Jeky deleted the issue-1867/zoom-observation branch September 6, 2026 11:56
@github-project-automation github-project-automation Bot moved this from Pending to Done in Taskdeck Execution Sep 6, 2026
@Chris0Jeky

Copy link
Copy Markdown
Owner Author

Fresh-context review record (coordinator, 2026-09-06; read-only Opus 5 reviewer over the diff against the merge base; route: the standing D-12 rule for Codex-session PRs — review, fix MEDIUM+ in-PR, merge, disposition comment).

VERDICT: SHIP, nothing fixed in-PR. Recorded for #1867: MEDIUM — the visualScale: 2 assertion echoes the spec's own synthetic stub; no production code reads visualViewport.scale, so the title's "scale policy" is not proven and the geometry poll is tautological for the same reason. LOW — the real pinch-zoom policy is the index.html meta tag (width=device-width, initial-scale=1.0, no maximum-scale/user-scalable=no), which the PR neither asserts nor pins; no WCAG 1.4.4 regression is enshrined. Hunks are disjoint from #2732's in the same file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

1 participant