Residuals from the PR #1864 review (TdDialog visual-viewport binding, #1821):
- Pinch-zoom is conflated with keyboard contraction —
useVisualViewport never consults visualViewport.scale, so zooming resizes/repositions every dialog on the same path as a keyboard contraction. Decide: ignore scale>1 events, or accept the behavior deliberately.
prefix option is documented "must start with --" but not validated — a bare prefix produces style keys Vue silently drops. A DEV-only warn would catch it.
- The geometric E2E is not gated by required CI — E2E Smoke / Cross-Browser report
skipping on the PR, so mobile-responsive.spec.ts geometry runs only locally. Consider adding the mobile-responsive spec to a gated lane, or record that it is local-evidence-only.
- At the <=640px breakpoint the
100vh/100dvh pairs on .td-dialog are dead (percentages win everywhere) — annotated in-PR; delete when next touched.
Source: PR #1864 review non-blocking items 2-4 + tidy-up. The review's item 1 (fallback-chain hole) was fixed in-PR.
Residuals from the PR #1864 review (TdDialog visual-viewport binding, #1821):
useVisualViewportnever consultsvisualViewport.scale, so zooming resizes/repositions every dialog on the same path as a keyboard contraction. Decide: ignore scale>1 events, or accept the behavior deliberately.prefixoption is documented "must start with --" but not validated — a bare prefix produces style keys Vue silently drops. A DEV-only warn would catch it.skippingon the PR, somobile-responsive.spec.tsgeometry runs only locally. Consider adding the mobile-responsive spec to a gated lane, or record that it is local-evidence-only.100vh/100dvhpairs on.td-dialogare dead (percentages win everywhere) — annotated in-PR; delete when next touched.Source: PR #1864 review non-blocking items 2-4 + tidy-up. The review's item 1 (fallback-chain hole) was fixed in-PR.