Skip to content

[Frontend] TdDialog/useVisualViewport residuals: pinch-zoom scale, prefix validation, ungated geometric E2E (PR #1864 review) #1867

Description

@Chris0Jeky

Residuals from the PR #1864 review (TdDialog visual-viewport binding, #1821):

  1. Pinch-zoom is conflated with keyboard contractionuseVisualViewport never consults visualViewport.scale, so zooming resizes/repositions every dialog on the same path as a keyboard contraction. Decide: ignore scale>1 events, or accept the behavior deliberately.
  2. prefix option is documented "must start with --" but not validated — a bare prefix produces style keys Vue silently drops. A DEV-only warn would catch it.
  3. The geometric E2E is not gated by required CI — E2E Smoke / Cross-Browser report skipping on the PR, so mobile-responsive.spec.ts geometry runs only locally. Consider adding the mobile-responsive spec to a gated lane, or record that it is local-evidence-only.
  4. At the <=640px breakpoint the 100vh/100dvh pairs on .td-dialog are dead (percentages win everywhere) — annotated in-PR; delete when next touched.

Source: PR #1864 review non-blocking items 2-4 + tidy-up. The review's item 1 (fallback-chain hole) was fixed in-PR.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Priority IIIValuable but unscheduled: residuals, tech-debt, performance, depth work.frontendPrimary implementation impact in Vue/TypeScript UI and client runtime.testingTest coverage, harnesses, regression prevention, and verification pipeline work.uxDiscoverability, accessibility, interaction model, and user workflow quality.

    Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions