Skip to content

test(ci): allow slow Windows shell output drain - #2556

Merged
Chris0Jeky merged 1 commit into
mainfrom
codex/issue-2135/high-volume-budget
Sep 4, 2026
Merged

test(ci): allow slow Windows shell output drain#2556
Chris0Jeky merged 1 commit into
mainfrom
codex/issue-2135/high-volume-budget

Conversation

@Chris0Jeky

Copy link
Copy Markdown
Owner

Summary

  • allow the synthetic high-volume readiness burst 10 seconds to drain on Git Bash for Windows
  • give only this high-volume test a 60-second test budget
  • keep production launcher defaults unchanged

Relates to #2135

Verification

  • node --check scripts/ci/dev-up.test.mjs
  • node --test --test-concurrency=1 --test-timeout=60000 --test-name-pattern=high-volume stdout and stderr scripts/ci/dev-up.test.mjs (2/2)
  • git diff --check

The change addresses the proven Bash-on-Windows fixture timeout that blocked unrelated PRs #2517 and #2521.

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, add credits to your account and enable them for code reviews in your settings.

@Chris0Jeky Chris0Jeky left a comment

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coordinator review (fresh pass, head 8c0779f): SHIP. The diff is limited to the synthetic high-volume fixture: it gives Git Bash on Windows 10 seconds to drain the 4,000-line burst and 60 seconds for this test only. Production launcher defaults and readiness semantics are unchanged. Local PowerShell and Bash focused runs pass 2/2; syntax and diff checks pass. No correctness, security, or data-loss blocker found.

@Chris0Jeky Chris0Jeky left a comment

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Second coordinator pass after hosted verification (head 8c0779f): SHIP. The full required matrix is green, including the previously problematic Windows frontend/API lanes and E2E smoke (attempt 3). The diff remains limited to the synthetic high-volume test budget; no production timeout or launcher behavior changed. No correctness, security, or data-loss blocker found.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

1 participant