fix(inbox): preserve capture writes across list races - #2517
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
The connector usage-limit notice is informational, not a review finding. This PR is being checked through the independent coordinator review path; no code action is requested from this notice. |
Chris0Jeky
left a comment
There was a problem hiding this comment.
Coordinator two-pass adversarial review at exact head d71e6ba: no CRITICAL/HIGH findings in the two changed files (captureStore.ts and captureStore.spec.ts). The PR's intended generation fixes are present: successful batch writes bump detail/list generations before reconciliation, uncached triage avoids a false list-generation bump, and explicit list loads retain latest-load-wins behavior. Hosted Windows Frontend Unit is red only in unrelated scripts/ci/dev-up.test.mjs tests (PowerShell reset-seed, PowerShell cancellation timeout, Bash Vite fallback); the failure trace does not touch this PR's changed files. Local targeted store proof was 65/65, with typecheck/ESLint/diff clean from the original pass. No fix is justified in this issue PR; the unrelated launcher cohort remains the tracked CI substrate blocker.
Chris0Jeky
left a comment
There was a problem hiding this comment.
Coordinator re-review after main refresh (head fce5139, base f965098): SHIP on the #2464 delta. The live diff remains limited to captureStore.ts and its store spec; the base refresh only incorporated already-merged #2548 and #2518 changes. The new hosted run is still pending, and the prior Windows failure was the shared high-volume launcher fixture now covered by #2556. No new correctness, security, or data-loss blocker found.
Chris0Jeky
left a comment
There was a problem hiding this comment.
Coordinator final re-review after #2556 landed (head bf08386, base b8878c9): SHIP on the #2464 delta. The live diff remains limited to captureStore.ts and its store spec; the high-volume launcher repair is now in main. Refreshed hosted checks are pending. No new correctness, security, or data-loss blocker found.
Summary
Proof
This addresses the direct batch/list-generation defects in #2464. The separate LOW-2 cosmetic deadline warning remains intentionally open for a polling-policy follow-up.
Refs #2464