Add icon and README to CLI-installed BAML extension - #4292
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
⏭️ Performance benchmarks were skippedPerf benchmarks (CodSpeed) are opt-in on pull requests — they no longer run on every push. They always run automatically after merge to To run them on this PR, do any of the following, then push a commit (or re-run CI):
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughThe VS Code extension now includes BAML branding and installation documentation. Release tooling updates JSON package versions and validates that VSIX files contain the README and logo while continuing to reject native binaries. ChangesVS Code extension assets
Release packaging
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Binary size checks passed✅ 7 passed
Generated by |
665e4a6 to
cf4f08d
Compare
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
🧹 Nitpick comments (1)
scripts/tests/test_baml_language_version.py (1)
99-99: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick winCover the comma-preserving branch.
This fixture places
"version"last. It tests key ordering and the no-comma case, but it does not verify that a comma remains when another property follows. Add a field after"version"or testreplace_json_versiondirectly.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@scripts/tests/test_baml_language_version.py` at line 99, Add coverage for the comma-preserving branch in the fixture around replace_json_version by placing another JSON property after "version", or by directly testing replace_json_version with a following property, while retaining the existing ordering and no-comma coverage.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@scripts/tests/test_baml_language_version.py`:
- Line 99: Add coverage for the comma-preserving branch in the fixture around
replace_json_version by placing another JSON property after "version", or by
directly testing replace_json_version with a following property, while retaining
the existing ordering and no-comma coverage.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro Plus
Run ID: 6bf2f732-899b-4518-9960-eff428e10627
⛔ Files ignored due to path filters (1)
typescript2/app-vscode-ext/baml-logo.pngis excluded by!**/*.png
📒 Files selected for processing (5)
.github/workflows/release-baml-language.ymlscripts/baml-language-versionscripts/tests/test_baml_language_version.pytypescript2/app-vscode-ext/README.mdtypescript2/app-vscode-ext/package.json
🚧 Files skipped from review as they are similar to previous changes (2)
- typescript2/app-vscode-ext/README.md
- typescript2/app-vscode-ext/package.json
Summary
Why
The CLI-installed extension did not declare an icon or include user-facing installation and update documentation. The release workflow also did not verify those files were present in the packaged VSIX.
Linear: https://linear.app/boundaryml2/issue/B-1030/add-icon-file-icons-readme-and-update-command-for-cli-installed
Validation
cargo build --manifest-path baml_language/Cargo.toml --release --bin baml-cli --bin baml-pack-hostCI=true pnpm --dir typescript2 run vscode:packagebaml-cli ide install --output-dirextension/readme.mdandextension/baml-logo.pngand excludes native binariesgit diff --checkpassSummary by CodeRabbit
New Features
Bug Fixes