Skip to content

Transparent file icon for vscode - #4336

Merged
2kai2kai2 merged 1 commit into
canaryfrom
kai/transparent-file-icon
Aug 6, 2026
Merged

Transparent file icon for vscode#4336
2kai2kai2 merged 1 commit into
canaryfrom
kai/transparent-file-icon

Conversation

@2kai2kai2

@2kai2kai2 2kai2kai2 commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

The extension icon is still the full square BAML logo but this switches the file icons to have a transparent background.

Summary by CodeRabbit

  • Style
    • Updated the VS Code BAML extension to use dedicated dark- and light-theme lamb icons.
    • Improved icon appearance across supported editor themes.

The extension icon is still the full square BAML logo but this switches the file icons to have a transparent background.
@vercel

vercel Bot commented Aug 6, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
beps Ready Ready Preview Aug 6, 2026 5:23pm
promptfiddle2 Ready Ready Preview Aug 6, 2026 5:23pm

Request Review

@vercel
vercel Bot temporarily deployed to Preview – beps August 6, 2026 17:14 Inactive
@coderabbitai

coderabbitai Bot commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 8e219277-358c-4c92-af8e-c0e6ba4ab81c

📥 Commits

Reviewing files that changed from the base of the PR and between bffb53e and 3139131.

⛔ Files ignored due to path filters (2)
  • typescript2/app-vscode-ext/baml-lamb-dark.svg is excluded by !**/*.svg
  • typescript2/app-vscode-ext/baml-lamb-light.svg is excluded by !**/*.svg
📒 Files selected for processing (1)
  • typescript2/app-vscode-ext/package.json

📝 Walkthrough

Walkthrough

The VS Code BAML language extension now uses separate dark and light lamb SVG icons in its language contribution metadata.

Changes

VS Code extension icon update

Layer / File(s) Summary
Theme-specific icon declarations
typescript2/app-vscode-ext/package.json
The language contribution icons now reference baml-lamb-dark.svg and baml-lamb-light.svg instead of baml-logo.png.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Possibly related PRs

  • BoundaryML/baml#4292: Both PRs modify VS Code extension icon declarations in typescript2/app-vscode-ext/package.json.

Suggested reviewers: rossirpaulo, aaronvg, codeshaunted

Poem

A rabbit hops where lambs now gleam,
Dark by night and light by beam.
The old logo rests in peace,
SVG icons bring release.
“BAML shines!” the rabbit sings.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly describes the main change: transparent file icons for the VS Code extension.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch kai/transparent-file-icon

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@vercel
vercel Bot temporarily deployed to Preview – promptfiddle2 August 6, 2026 17:23 Inactive
@github-actions

github-actions Bot commented Aug 6, 2026

Copy link
Copy Markdown

⏭️ Performance benchmarks were skipped

Perf benchmarks (CodSpeed) are opt-in on pull requests — they no longer run on every push. They always run automatically after merge to canary/main.

To run them on this PR, do any of the following, then push a commit (or re-run CI):

  • Add RUN_CODSPEED=1 to the PR description, or
  • Include run-perf or /perf in the PR title or any commit message.

@2kai2kai2
2kai2kai2 added this pull request to the merge queue Aug 6, 2026
Merged via the queue into canary with commit 3c7e27f Aug 6, 2026
36 of 37 checks passed
@2kai2kai2
2kai2kai2 deleted the kai/transparent-file-icon branch August 6, 2026 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant