feat(comments): validation checkbox for validators [Assety s více úrovněmi vláken] - #2276
Merged
Conversation
The server now stores an explicit thread type (validation vs public
discussion, BlenderKit-server#3516). Validators get a 'Validation
comment' checkbox when starting a new thread; replies inherit the
thread's type so the checkbox is hidden for them. The flag is passed
through the Client, which needs a matching field in CreateCommentData
and CommentPostData to forward it; until both are released the server
classifies validator template comments ('Validation status: ...') by
their text, so older add-on versions keep working unchanged.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Most validator-started threads are validation comments; the reset after posting returns to the checked default accordingly. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2276 +/- ##
==========================================
- Coverage 32.25% 32.24% -0.01%
==========================================
Files 85 85
Lines 26688 26692 +4
==========================================
Hits 8608 8608
- Misses 18080 18084 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Operator tests for the codecov patch gap in ui_panels.execute: a validator starting a thread sends is_validation and the checkbox resets to its checked default; replies and non-validators never send it. client_lib.create_comment is stubbed per the established BKIT_PROFILE save/restore pattern. Not run locally (no Blender binary on this machine) - verified by the CI matrix. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Recording-layout fake exercises AssetPopupCard.draw_comment_response directly: the checkbox draws for validators on new threads only, never on replies or for non-validators. Covers the last uncovered patch lines; nested with-statements keep Python 3.9 (Blender 3.0) parsing. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add-on side of validation-thread marking (server: BlenderKit/BlenderKit-server#3516).
canEditAllAssets) get a Validation comment checkbox when starting a new comment thread; hidden on replies, which inherit the thread's type server-side.client_lib.create_commentpassesis_validationto the Client; the flag resets after posting.🤖 Generated with Claude Code