feat(comments): forward is_validation to the server [Assety s více úrovněmi vláken] - #37
Merged
Merged
Conversation
The server stores an explicit thread type for comments (BlenderKit-server#3516); validators mark new threads via the add-on (BlenderKit#2276). Typed structs drop unknown fields, so both CreateCommentData (from the add-on) and CommentPostData (to the server) gain the boolean; false is omitted-equivalent for older add-ons and ignored by older servers. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Companion to BlenderKit/BlenderKit-server#3516 (validation-thread type) and BlenderKit/Blendkit#2276 (add-on checkbox).
Adds
is_validationtoCreateCommentData(accepted from the add-on) andCommentPostData(forwarded to the server), and copies it through inCreateComment.falseis equivalent to omitting the field, so older add-ons and older servers are unaffected in either direction.Note: not built locally (module requires go >= 1.26, local toolchain is 1.22); gofmt clean, three mechanical lines mirroring the neighboring fields — please rely on CI for the build.
🤖 Generated with Claude Code