Skip to content

fix(report): the console summary counted the wrong skips #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
BitHighlander merged 1 commit into from
Aug 21, 2026
Merged

fix(report): the console summary counted the wrong skips #43

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions scripts/generate-test-report.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2845,13 +2845,12 @@ def _section_state(s):
ran = JUNIT_CENSUS['ran']
if ran:
pb.gap(3)
skipped = JUNIT_CENSUS['skipped']
for line in _w('Scope: this report is a curated catalog of %d tests. The CI run collected %d '
'(%d of them native firmware unit tests); %d SKIPPED and did not execute, '
'usually because the emulator predates the firmware the test targets -- a skip '
'is not evidence the feature works. Absence from this report is NOT '
'evidence that a feature is untested -- check the JUnit artifacts.'
% (total, ran, JUNIT_CENSUS['native'], skipped), 100):
% (total, ran, JUNIT_CENSUS['native'], JUNIT_CENSUS['skipped']), 100):
pb.text(8, line, color=GRAY)
pb.gap(6)
pb.text(12, 'Sections', bold=True)
Expand Down Expand Up @@ -2994,6 +2993,9 @@ def _section_state(s):

pb.finish()
pdf.write(output_path)
assert passed + failed + skipped + missing == total, (
'catalog counts do not reconcile: %d+%d+%d+%d != %d'
% (passed, failed, skipped, missing, total))
print(f'{output_path}: fw={fw_version}, {len(active)} sections, {total} tests '
f'({passed} passed, {failed} failed, {skipped} skipped, {missing} pending)')

Expand Down
Loading