fix(report): the console summary counted the wrong skips - #43
Merged
Conversation
render() computes the catalog's own skip count, then the scope paragraph
rebound the same name to the run-wide census:
skipped = sum(... for t in s[5] if _lookup(...) == 'skip') # catalog
...
skipped = JUNIT_CENSUS['skipped'] # whole run
so the line CI operators actually read --
N sections, 374 tests (323 passed, 0 failed, 3 skipped, 48 pending)
printed the whole run's skips inside a breakdown of the catalog. The four
numbers did not add up to the total, and the error ran in the alarming
direction: it inflates skips, which reads as "lots of this was not exercised"
against a catalog where only three entries were actually gated.
Use the census value inline where the paragraph needs it and leave `skipped`
meaning one thing.
Added the assertion that would have caught it, since the breakdown is only
ever right when it reconciles:
assert passed + failed + skipped + missing == total
Now: 374 tests (323 passed, 0 failed, 3 skipped, 48 pending) -> 374.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
render()computes the catalog's own skip count, then the scope paragraph rebound the same name to the run-wide census:So the line CI operators actually read —
— printed the whole run's skips inside a breakdown of the catalog. The four numbers did not add up to the total, and the error ran in the alarming direction: it inflates skips, which reads as "lots of this was not exercised" against a catalog where only three entries were actually gated.
Uses the census value inline where the paragraph needs it, so
skippedmeans one thing. Plus the assertion that would have caught it, since the breakdown is only ever right when it reconciles: