Skip to content

Fix PHP 8.4 external extension ABI #2476

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
chubes4 wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Fix PHP 8.4 external extension ABI #2476

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4373cbe
fix(runtime): pin PHP 8.4 extension ABI
chubes4 Sep 3, 2026
f048417
fix(runtime): restore PHP 8.3 overlay dependency baseline
chubes4 Sep 3, 2026
34046dc
fix(runtime): carry patched PHP 8.3 runtime for 3.1.52
chubes4 Sep 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,11 @@ artifacts/
runtime-overlays/*
!runtime-overlays/php-wasm-node-8-3/
!runtime-overlays/php-wasm-node-8-3/**
runtime-overlays/php-wasm-node-8-3/node_modules/
!runtime-overlays/php-wasm-node-8-4/
!runtime-overlays/php-wasm-node-8-4/**
!runtime-overlays/provenance.json
!runtime-overlays/provenance-8-4.json
scripts/uploads/
*.tsbuildinfo
.DS_Store
Expand Down
421 changes: 226 additions & 195 deletions npm-shrinkwrap.json
View file
Open in desktop

Large diffs are not rendered by default.

10 changes: 6 additions & 4 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,9 @@
"scripts/apply-development-patches.mjs",
"patches",
"runtime-overlays/php-wasm-node-8-3",
"runtime-overlays/php-wasm-node-8-4",
"runtime-overlays/provenance.json",
"runtime-overlays/provenance-8-4.json",
"README.md",
"LICENSE"
],
Expand Down Expand Up @@ -138,6 +140,7 @@
"test:playground-custom-archive-cache": "tsx tests/playground-custom-archive-cache.test.ts && tsx tests/playground-custom-archive-cache-process.test.ts && tsx tests/playground-custom-archive-cache.integration.test.ts",
"test:phpunit-runtime-rejection": "tsx tests/phpunit-runtime-rejection.test.ts",
"test:php-wasm-runtime-rejection-any-command": "tsx tests/php-wasm-runtime-rejection-any-command.test.ts",
"test:php-wasm-external-extension-abi": "tsx tests/php-wasm-external-extension-abi.test.ts",
"test:browser-visual-compare-layout-drift": "tsx tests/browser-visual-compare-layout-drift.test.ts",
"test:browser-visual-compare-capture-reliability": "tsx tests/browser-visual-compare-capture-reliability.test.ts",
"test:browser-visual-compare-url-capture": "npm run build && tsx tests/browser-visual-compare-url-capture.test.ts",
Expand Down Expand Up @@ -200,10 +203,10 @@
"@automattic/wp-codebox-core": "file:packages/runtime-core",
"@automattic/wp-codebox-playground": "file:packages/runtime-playground",
"@php-wasm/node-8-3": "file:runtime-overlays/php-wasm-node-8-3",
"@php-wasm/node-8-4": "3.1.46",
"@php-wasm/universal": "3.1.46",
"@php-wasm/node-8-4": "file:runtime-overlays/php-wasm-node-8-4",
"@php-wasm/universal": "3.1.52",
"@types/pngjs": "^6.0.5",
"@wp-playground/cli": "3.1.46",
"@wp-playground/cli": "3.1.52",
"@wp-playground/wordpress-builds": "0.9.19",
"abort-controller": "^3.0.0",
"accepts": "^1.3.8",
Expand Down Expand Up @@ -388,7 +391,6 @@
"yargs-parser": "^21.1.1"
},
"overrides": {
"@php-wasm/util": "3.1.46",
"ajv": "^8.20.0",
"express": "^4.22.2",
"qs": "^6.15.2",
Expand Down
12 changes: 6 additions & 6 deletions packages/runtime-playground/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,12 +22,12 @@
},
"dependencies": {
"@automattic/wp-codebox-core": "file:../runtime-core",
"@php-wasm/node": "3.1.46",
"@php-wasm/universal": "3.1.46",
"@wp-playground/blueprints": "3.1.46",
"@wp-playground/cli": "3.1.46",
"@wp-playground/storage": "3.1.46",
"@wp-playground/wordpress": "3.1.46",
"@php-wasm/node": "3.1.52",
"@php-wasm/universal": "3.1.52",
"@wp-playground/blueprints": "3.1.52",
"@wp-playground/cli": "3.1.52",
"@wp-playground/storage": "3.1.52",
"@wp-playground/wordpress": "3.1.52",
"@wp-playground/wordpress-builds": "0.9.19",
"@types/pngjs": "^6.0.5",
"pixelmatch": "^7.2.0",
Expand Down
20 changes: 10 additions & 10 deletions patches/@wp-playground+cli+3.1.46.patch → patches/@wp-playground+cli+3.1.52.patch
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,25 +1,25 @@
diff --git a/node_modules/@wp-playground/cli/run-cli-DKYOp4UU.js b/node_modules/@wp-playground/cli/run-cli-DKYOp4UU.js
index e22c476..ed7c114 100644
--- a/node_modules/@wp-playground/cli/run-cli-DKYOp4UU.js
+++ b/node_modules/@wp-playground/cli/run-cli-DKYOp4UU.js
@@ -536,6 +536,7 @@ class Yt {
diff --git a/node_modules/@wp-playground/cli/run-cli-DnHtP68W.js b/node_modules/@wp-playground/cli/run-cli-DnHtP68W.js
index 2617fa5..5b0ab69 100644
--- a/node_modules/@wp-playground/cli/run-cli-DnHtP68W.js
+++ b/node_modules/@wp-playground/cli/run-cli-DnHtP68W.js
@@ -536,6 +536,7 @@ class Qt {
mountsBeforeWpInstall: this.args["mount-before-install"] || [],
mountsAfterWpInstall: this.args.mount || [],
processId: t.processId,
+ environmentVariables: this.args.phpEnv,
followSymlinks: this.args.followSymlinks === !0,
trace: this.args.experimentalTrace === !0,
extensions: Ve(
@@ -777,6 +778,7 @@ class er {
extensions: Ue(
@@ -777,6 +778,7 @@ class tr {
mountsBeforeWpInstall: this.args["mount-before-install"] || [],
mountsAfterWpInstall: this.args.mount || [],
processId: t.processId,
+ environmentVariables: this.args.phpEnv,
followSymlinks: this.args.followSymlinks === !0,
trace: this.args.experimentalTrace === !0,
extensions: Ve(this.args),
extensions: Ue(this.args),
diff --git a/node_modules/@wp-playground/cli/worker-thread-v1.js b/node_modules/@wp-playground/cli/worker-thread-v1.js
index 93b7099..a8ecae8 100644
index c48b18e..5ef8989 100644
--- a/node_modules/@wp-playground/cli/worker-thread-v1.js
+++ b/node_modules/@wp-playground/cli/worker-thread-v1.js
@@ -125,6 +125,7 @@ function V(r, e) {
Expand All @@ -40,7 +40,7 @@ index 93b7099..a8ecae8 100644
const i = new _(), [c, p] = y(
new F(new f()),
diff --git a/node_modules/@wp-playground/cli/worker-thread-v2.js b/node_modules/@wp-playground/cli/worker-thread-v2.js
index fb79a59..5197c68 100644
index 5a329a4..797870d 100644
--- a/node_modules/@wp-playground/cli/worker-thread-v2.js
+++ b/node_modules/@wp-playground/cli/worker-thread-v2.js
@@ -136,6 +136,7 @@ function V(r, e) {
Expand Down
3 changes: 2 additions & 1 deletion patches/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
# Temporary Playground Overlay

`@wp-playground+cli+3.1.46.patch` makes blueprint worker threads rethrow fatal
`@wp-playground+cli+3.1.52.patch` passes runtime environment variables into PHP
worker threads and makes those workers rethrow fatal
`WebAssembly.RuntimeError` rejections originating from `php.wasm` after logging
them. Detection uses the error name because PHP-WASM errors may cross JavaScript
realm boundaries where `instanceof` is false. Other unhandled rejections retain
Expand Down
Loading
Loading