Fix PHP 8.4 external extension ABI - #2476
Draft
chubes4 wants to merge 3 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2474.
Summary
Status: blocked, do not merge
CI is red on
tests/mysqli-poll.integration.test.tsand that failure is real, not flaky.Bumping the Playground driver stack to 3.1.52 skews it against the PHP 8.3 overlay, whose binaries are built from 3.1.46 plus an unreleased
php_wasm.cmysqli_pollpatch. A 3.1.52 driver against 3.1.46-patched WASM hangs insidezif_mysqli_polland the recipe times out after 180s.The 8.3 overlay in this branch is byte-identical to
main; the skew comes from the driver bump alone.Upstream dependencies
mysqli_polltimeout fix#4108 is expected in the next weekly release (~3.1.53), at which point this overlay can be deleted outright.
Resolving the red requires one of:
php_wasm.c, so a release rebuilds every version and mode)Verified
npm run test:php-wasm-external-extension-abinpm run test:php-wasm-runtime-rejection-any-commandnpm run test:phpunit-runtime-rejectionnpm run test:release-package-coveragenpm run build,npx patch-package --check,git diff --checkThe ABI overlay itself is proven: a PHP 8.4 JSPI extension workload that previously failed at startup with an unnamed
TypeError: resolved is not a functionnow boots PHP 8.4.25, loads its extension, and reaches command dispatch.AI assistance
OpenAI GPT-5.6 Sol via OpenCode traced the PHP.wasm ABI mismatch, assembled the provenance-bound overlay, implemented the packaging and regression coverage, diagnosed the mysqli_poll CI failure, and drafted this description. Reviewed by Chris Huber.