Skip to content

Premium Analytics: expand the feedback confirmation message #52107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chihsuan merged 1 commit into from
Sep 9, 2026
Merged

Premium Analytics: expand the feedback confirmation message #52107

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions projects/packages/premium-analytics/changelog/uni-758-feedback-confirmation
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
Significance: patch
Type: changed

Feedback: tell readers where their feedback went and that they can send more, instead of a one-line thank you.
11 changes: 10 additions & 1 deletion projects/packages/premium-analytics/routes/dashboard/components/feedback/feedback-modal.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,8 +86,17 @@ export function FeedbackModal( { onClose }: FeedbackModalProps ) {
<>
<Dialog.Content>
<Notice.Root intent="success">
<Notice.Title>
{ __(
'Thanks, your feedback has gone to the team.',
'jetpack-premium-analytics-pkg'
) }
</Notice.Title>
<Notice.Description>
{ __( 'Thank you. This helps.', 'jetpack-premium-analytics-pkg' ) }
{ __(
"It'll help us decide what to fix before the new Traffic tab replaces the old one. You can send more any time from the same menu.",
'jetpack-premium-analytics-pkg'
) }
</Notice.Description>
</Notice.Root>
</Dialog.Content>
Expand Down
12 changes: 10 additions & 2 deletions ...remium-analytics/routes/dashboard/components/options-menu/dashboard-options-menu.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,8 +149,12 @@ describe( 'DashboardOptionsMenu', () => {

// Scoped to the dialog: `Notice` also mirrors the text into the a11y-speak live
// region on `body`, so an unscoped query matches twice.
const dialog = within( screen.getByRole( 'dialog' ) );
expect( dialog.getByText( 'Thanks, your feedback has gone to the team.' ) ).toBeInTheDocument();
expect(
within( screen.getByRole( 'dialog' ) ).getByText( 'Thank you. This helps.' )
dialog.getByText(
"It'll help us decide what to fix before the new Traffic tab replaces the old one. You can send more any time from the same menu."
)
).toBeInTheDocument();
expect( screen.queryByRole( 'radiogroup' ) ).not.toBeInTheDocument();

Expand Down Expand Up @@ -296,8 +300,12 @@ describe( 'the Happiness copy of the feedback', () => {
await user.type( screen.getByRole( 'textbox' ), 'Charts load slowly' );
await user.click( screen.getByRole( 'button', { name: 'Send feedback' } ) );

const dialog = within( screen.getByRole( 'dialog' ) );
expect( dialog.getByText( 'Thanks, your feedback has gone to the team.' ) ).toBeInTheDocument();
expect(
within( screen.getByRole( 'dialog' ) ).getByText( 'Thank you. This helps.' )
dialog.getByText(
"It'll help us decide what to fix before the new Traffic tab replaces the old one. You can send more any time from the same menu."
)
).toBeInTheDocument();
} );
} );
Expand Down
4 changes: 4 additions & 0 deletions projects/plugins/jetpack/changelog/uni-758-feedback-confirmation
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
Significance: patch
Type: enhancement

Premium Analytics: tell readers where their feedback went and that they can send more, instead of a one-line thank you.
4 changes: 4 additions & 0 deletions projects/plugins/premium-analytics/changelog/uni-758-feedback-confirmation
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
Significance: patch
Type: changed

Feedback: tell readers where their feedback went and that they can send more, instead of a one-line thank you.
Loading