Premium Analytics: expand the feedback confirmation message - #52107
Premium Analytics: expand the feedback confirmation message#52107chihsuan wants to merge 1 commit into
Conversation
|
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 Follow this PR Review Process:
If you have questions about anything, reach out in #jetpack-developers for guidance! Jetpack plugin: The Jetpack plugin has different release cadences depending on the platform:
If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. Premium Analytics plugin: No scheduled milestone found for this plugin. If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. |
Code Coverage SummaryThis PR did not change code coverage! That could be good or bad, depending on the situation. Everything covered before, and still is? Great! Nothing was covered before? Not so great. 🤷 |
Nikschavan
left a comment
There was a problem hiding this comment.
Thank you, the changes look good.
dognose24
left a comment
There was a problem hiding this comment.
LGTM! Copy matches UNI-758, Notice.Title is available in @wordpress/ui 0.21, and both the success and endpoint-failure paths are covered in the tests.
Fixes UNI-758
Proposed changes
Notice.Titleplus aNotice.Descriptionso the headline and the explanation read as two parts.The copy is Gary's from UNI-758, with a comma added to the first line ("Thanks, your feedback has gone to the team.") because the issue text was missing one.
Related product discussion/links
Does this pull request change what data or activity we track or use?
No. The submission path is untouched: the same Tracks event fires, and a non-empty comment still reaches the Stats feedback endpoint.
Testing instructions
Note: Step 3 sends a real submission. The dashboard does not pass
is_testing, so a comment reaches Happiness and opens a Zendesk ticket. Either addis_testing: trueto the body insubmitStatsUserFeedbackwhile you test, or resolve the ticket afterwards.