-
Notifications
You must be signed in to change notification settings - Fork 18
fix ci #11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
fix ci #11
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -2,38 +2,31 @@ | |
| name: Make | ||
|
|
||
| on: | ||
| push: | ||
| branches: | ||
| - "**" | ||
| pull_request: | ||
| branches: | ||
| - master | ||
|
|
||
| concurrency: | ||
| group: ${{ github.workflow }}-${{ github.ref }} | ||
| cancel-in-progress: true | ||
|
|
||
| jobs: | ||
| build: | ||
| runs-on: ${{ matrix.os }} | ||
| timeout-minutes: 120 | ||
| timeout-minutes: 12 | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
The install paths in Useful? React with 👍 / 👎. |
||
| strategy: | ||
| matrix: | ||
| os: | ||
| - ubuntu-latest | ||
| - windows-latest | ||
|
|
||
| steps: | ||
| - name: Checkout | ||
| uses: actions/checkout@v7 | ||
| with: | ||
| submodules: true | ||
| submodules: recursive | ||
|
|
||
| - name: Build on Linux | ||
| if: runner.os == 'Linux' | ||
| if: runner.os != 'Windows' | ||
| shell: bash | ||
| run: bash -x make.sh build | ||
| run: bash -x '.github/workflows/make.sh' build | ||
|
|
||
| - name: Build on Windows | ||
| if: runner.os == 'Windows' | ||
| shell: powershell | ||
| run: pwsh -File make.ps1 build | ||
| run: pwsh -File '.github/workflows/make.ps1' build | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The deleted
make.ymlalso ran onpushfor every branch, but this replacement only runs forpull_requestevents targetingmaster. In this repo the active branch ismain, so direct pushes to branches stop getting the Make build at all, and PRs targetingmainare not covered by this workflow either. Please keep the push trigger or update the PR branch filter while moving the scripts.Useful? React with 👍 / 👎.