fix ci - #11
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0f0fbcac36
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| pull_request: | ||
| branches: | ||
| - master |
There was a problem hiding this comment.
The deleted make.yml also ran on push for every branch, but this replacement only runs for pull_request events targeting master. In this repo the active branch is main, so direct pushes to branches stop getting the Make build at all, and PRs targeting main are not covered by this workflow either. Please keep the push trigger or update the PR branch filter while moving the scripts.
Useful? React with 👍 / 👎.
| build: | ||
| runs-on: ${{ matrix.os }} | ||
| timeout-minutes: 120 | ||
| timeout-minutes: 12 |
There was a problem hiding this comment.
Keep enough time for fresh runner installs
The install paths in .github/workflows/make.ps1 and .github/workflows/make.sh still run on fresh GitHub-hosted runners before compiling; the Windows downloader alone allows up to 600 seconds, and the Linux path installs the full Lazarus package set. Reducing the job timeout from 120 to 12 minutes means a normal dependency install can consume almost the whole budget and the matrix leg can be killed before compilation starts, making CI flaky even when the build is healthy.
Useful? React with 👍 / 👎.
Hello, @Al-Muhandis
I've fixed the CI
Best regards
Artem