Skip to content

fix ci - #11

Open
theavege wants to merge 4 commits into
Al-Muhandis:masterfrom
theavege:fix/ci
Open

fix ci#11
theavege wants to merge 4 commits into
Al-Muhandis:masterfrom
theavege:fix/ci

Conversation

@theavege

@theavege theavege commented Aug 23, 2026

Copy link
Copy Markdown
Contributor

Hello, @Al-Muhandis

I've fixed the CI

Best regards
Artem

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 0f0fbcac36

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines 5 to 7
pull_request:
branches:
- master

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Restore push-triggered builds

The deleted make.yml also ran on push for every branch, but this replacement only runs for pull_request events targeting master. In this repo the active branch is main, so direct pushes to branches stop getting the Make build at all, and PRs targeting main are not covered by this workflow either. Please keep the push trigger or update the PR branch filter while moving the scripts.

Useful? React with 👍 / 👎.

build:
runs-on: ${{ matrix.os }}
timeout-minutes: 120
timeout-minutes: 12

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Keep enough time for fresh runner installs

The install paths in .github/workflows/make.ps1 and .github/workflows/make.sh still run on fresh GitHub-hosted runners before compiling; the Windows downloader alone allows up to 600 seconds, and the Linux path installs the full Lazarus package set. Reducing the job timeout from 120 to 12 minutes means a normal dependency install can consume almost the whole budget and the matrix leg can be killed before compilation starts, making CI flaky even when the build is healthy.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant