Rate limiting tweaks - #473
Merged
Merged
Conversation
yuenmichelle1
left a comment
Collaborator
There was a problem hiding this comment.
I have a couple of questions mostly regarding the change from hashed_token to current_user.
As far as I understand, token authentication for Talk happens in the application controller layer (See: application_controller.rb) and rack attack is middleware that happens before the controller. With current_user in rack_attack.rb not verifying token signature, I think forged tokens might allow attackers to throttle users incorrectly.
But I have not tested, just sniffed weird on a glimpse.
Member
Author
|
Forgery is possible enough that adding token verification is a good idea. Added that logic to the initializer. I also added the public key as secrets in the cluster and mounted them as volumes via the deployments. |
lcjohnso
approved these changes
Aug 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
post review: