Cleanup WalpaperLoaderTask - #260
Open
Donnnno wants to merge 12 commits into
Open
Conversation
updating dependencies and removing deprecations
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Got this message from the Play Console:
Improve your app's performance with bitmap image optimization
Your app manually downloads and decodes images from the network in the following places: Decoded in
candybar.lib.tasks.WallpaperPropertiesLoaderTask.runDownloaded incandybar.lib.helpers.WallpaperHelper.getStreamThis can lead to excessive memory usage, poor performance, and app crashes. To reduce memory usage, we recommend using an image loading library to automatically handle downsampling, caching, and memory management for you.Merge #251 first :)
Changes Made:
HttpURLConnectionviaWallpaperHelper.getStream()for fetching images.Glide.with(context).asFile().load(url).submit().get()to download the wallpaper. This leverages Glide's built-in networking (OkHttp) and automatic caching, preventing redundant downloads and reducing data usage.BitmapFactory.decodeStream) which loaded the entire bitmap into memory just to read dimensions.BitmapFactory.OptionswithinJustDecodeBounds = trueto extract dimensions and MIME type from the downloaded file without allocating memory for the full bitmap.assets:// URIsto Glide-compatible android_asset URIs, ensuring local wallpapers are also handled through the optimized pipeline.Generated with Google's built in Android studio AI