fix ggml_metal build break - #136
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
TensorSharp/.github/workflows/release-binaries.yml
Lines 225 to 226 in 06c932d
Fail release staging when the metallib is missing
When a macOS build does not produce mlx.metallib—for example after an upstream install-layout change—this branch only emits a warning and allows the release archives to be published. The preceding comment establishes that the file is mandatory and that the packaged MLX backend throws on first use without it, so this specific artifact should fail the workflow rather than producing a successful but unusable macOS release.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if (!string.IsNullOrWhiteSpace(cli.Urls)) | ||
| return cli.Urls.Trim(); |
There was a problem hiding this comment.
When --urls or ASPNETCORE_URLS contains the documented semicolon-separated endpoints, this returns the entire list as one string and Program.cs passes it to app.Run(string). That overload adds one address rather than parsing an ASP.NET Core URL list, so Kestrel attempts to parse a malformed single endpoint and startup fails; add each URL separately to app.Urls or otherwise use the host configuration's URL-list parsing.
Useful? React with 👍 / 👎.
Engine comparison — TensorSharp vs llama.cpp (PR smoke)No report artifact was produced — the benchmark failed before generating results (see the workflow logs). |
1 participant
No description provided.