SEO: Fix Internal Redirect type filter showing no results - #4323
SEO: Fix Internal Redirect type filter showing no results#4323finnar-bin wants to merge 1 commit into
Conversation
The "Internal" option in TYPE_FILTERS was keyed "internal", but the
table filters by comparing the raw targetType value ("page" | "external"
| "path") directly. The key mismatch meant selecting "Internal" always
produced an empty table. Also adds data-cy attributes to the type
filter menu items so they're testable, and extends the Cypress spec
with a regression-covering Type Filter suite.
Code Review — ✅ No blockers |
QA Review — ✅ PASSValidates #4318: Redirects - Internal Redirect Filter showing no results
Suggested Cypress coverage
|
Negative QANo reproducible edge-case failures found on the surfaces this PR changes. Also checked and working correctly
|
Coverage ReportOverall Coverage
Changed Files Coverage
|
Resolves #4318
Summary
internal, but redirect records actually store internal (page-linked) redirects withtargetType: "page"— so filtering by Internal never matched any rows.TYPE_FILTERSkey frominternaltopageso it matches the realtargetTypevalue, and addeddata-cyattributes to each type filter menu item for testability.Test plan
/redirects, create/seed an internal redirect, open the Type filter, select Internal — the redirect appears../node_modules/.bin/cypress run --spec "cypress/e2e/seo/redirects/redirects.spec.js"passes.