CI - Make the QA Review verdict deterministic - #4309
Open
agalin920 wants to merge 2 commits into
Open
Conversation
…asking for it
The verdict moved between runs of the same PR — 4 of 5 reported PASS, 3 of 4
reported INCONCLUSIVE — from three stacked causes:
1. The criteria list was re-derived each run with no granularity rule, so the
denominator itself moved.
2. The aggregation rule ("INCONCLUSIVE if nothing is clearly failing but you
couldn't confirm") said nothing about a mix of marks, so the model broke
the tie by feel, differently each time.
3. The grading scale offered "I can't judge this" as an outcome, so criteria
that were never checkable produced a mark the verdict had to absorb.
Across the last nine PRs with a QA Review comment, eight carried at least one
warning, and the warnings were two unrelated things sharing a mark: five were
"can't confirm without running the app" (a permanent property of a workflow
that never boots the app) and two were plainly-visible failures softened to a
warning by the tie-break rule.
The agent now partitions criteria before judging any of them — checkable from
the code, or needs a running app — and grades only the first group, with no
third mark. Runtime criteria are listed unscored rather than dropped, so the
count does not overstate coverage. The verdict is arithmetic on the marks,
computed in the post step: any failed criterion fails the check, otherwise it
passes, with the counts in the heading. INCONCLUSIVE is gone; it described the
workflow's permanent condition, not a per-PR result.
Criteria are also pinned across pushes — a new step reads the existing comment
and the prompt reuses its list verbatim, so a synchronize push re-judges a
fixed list instead of inventing a new one.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
finnar-bin
approved these changes
Sep 1, 2026
geodem127
approved these changes
Sep 1, 2026
Contributor
QA Review — ❌ FAIL — 1 of 4 code-checkable criteria not met, 3 need a running appNo linked issue found — change-only QA.
Not checkable from the code — needs a running app
Suggested Cypress coverageThis PR only changes |
Contributor
Code Review — ✅ No blockers |
Contributor
Negative QANo reproducible edge-case failures found on the surfaces this PR changes. Also checked and working correctly
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
QA Reviewverdict is not reproducible. The same PR can reportPASSon 4 of 5 criteria on one run andINCONCLUSIVEon 3 of 4 on the next. No linked issue — raised directly by @agalin920.Three causes, stacked:
Evidence
Pulled the⚠️ (only #4294 is clean), and the ⚠️ lines are two unrelated things sharing a mark:
<!-- cv-verifier -->comment from the last 12 PRs; nine have one. Eight of the nine carry at least onedata-cyabsent from both TitleTextFields), #4286.3 (CLAUDE.md left stale)Change
.github/workflows/claude-change-verifier.ymlonly.2 of 2 confirmedread as full coverage when an AC was never looked at. They have no downstream owner —claude-negative-qa.ymlexplicitly bars AC judgment — so they are the reviewer's manual checklist.✅ PASS — 2/2 code-checkable criteria confirmed, 1 needs a running app). The agent no longer writes a verdict; any marker it writes anyway is stripped.Fetch prior QA commentstep reads the existing comment; the prompt reuses its list verbatim, so asynchronizepush re-judges a fixed list instead of inventing a new one.