Manager UI - Delete 12 dead .less stylesheets - #4302
Open
agalin920 wants to merge 1 commit into
Open
Conversation
Phase 1 of #4265. None of these stylesheets can affect a rendered element: - 11 are orphans with zero importers anywhere in the repo. - FieldTypeUUID.less was imported by FieldTypeUUID.js, but that file dereferences no `styles.*` key and sets no className at all. Every .less goes through css-loader with `modules: { localIdentName: "[local]--[contenthash:base64:5]" }` (src/shell/webpack.config.js), so `.FieldTypeUUID` is emitted under a hashed name that nothing carries. The rules were already inert on dev. Removes the now-unused import from FieldTypeUUID.js; no other change to that file. Restyling these components would be a new design ask, not a revert of this commit. Closes #4300
Contributor
Coverage ReportOverall Coverage
Changed Files Coverage
|
This was referenced Aug 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #4300
Phase 1 of #4265, the
.lessretirement. Deletes the 12 stylesheets that cannot affect anything that renders — 269 lines, no insertions — takingsrc/from 82.lessfiles to 70 and from 3,110 LOC to 2,842. Eleven of them are referenced from nothing anywhere in the repo, verified by grepping each basename across the whole tree rather than justsrc/, and there is no dynamic route by which they could still be pulled in:require.contextappears nowhere, no glob or template-literal stylesheet import exists, and.lessis absent fromresolve.extensions(src/shell/webpack.config.js:106) so a bareimport "./Content"cannot resolve toContent.less.The twelfth needs its own sentence, because it is the only one that was imported.
src/shell/webpack.config.js:263-278runs every.lessthroughcss-loaderwithmodules: { localIdentName: "[local]--[contenthash:base64:5]" }— unconditionally; the dev/prod ternary above that rule wraps only thets-loader/babel-loaderentry. So.FieldTypeUUIDis emitted asFieldTypeUUID--<hash>, obtainable only from the importedstylesbinding.FieldTypeUUID.jsnever dereferences that binding, sets noclassNameat all, and spreads no props — it namesrequired,value,name,datatypeandonChangeindividually, so a parent cannot inject a class through it either, and itssxtargets the MUI global.MuiInputBase-readOnlyrather than a module class. Nothing else in the repo imports the file or hardcodes the class. Those rules therefore already apply to no element ondevtoday; deleting them changes no rendered pixel. Restoring that styling would be a new design ask, not a regression from this PR. The now-danglingimport stylesline goes with it, along with theimport cx from "classnames"beside it, which is unused for the same reason.No colour or token work is included, so this phase is independent of #4264. Both
npm run build:devandnpm run build:stagecompile the branch with zero errors — the latter cacheless by construction, since webpack's filesystem cache is enabled only whenNODE_ENV === "development"— which is the check that matters here: a resolving build is the only way to prove no importer was left dangling.tsc --noEmitreports no errors.