Cypress: Code App - Editor - #4053
Open
geodem127 wants to merge 17 commits into
Open
Conversation
geodem127
force-pushed
the
test/code-app-editor-2
branch
from
May 6, 2026 20:29
27eccf2 to
1d11773
Compare
- Use sdk.token instead of a bare getAuthToken() call, which only worked by relying on cached auth state from an earlier call - Add missing content-type header on the script fetch POST, which the API needs to parse the JSON body (was silently failing) - Simplify async flow to match content.ts conventions - Add cypress/e2e/code/seed.spec.js plus view/stylesheet/script fixtures exercising all three seed:code branches Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
…ding # Conflicts: # cypress/index.d.ts
Keeping the fixtures — other PRs building on this branch will use them. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Will be added in the actual PR that consumes them. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Addresses review: silent null returns turned real API failures into confusing downstream null-reference errors in consuming tests. Matches the fail-loud pattern content.ts already uses. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
geodem127
force-pushed
the
test/code-app-data-seeding
branch
from
July 20, 2026 20:07
cf17404 to
9b6cad5
Compare
geodem127
marked this pull request as ready for review
July 27, 2026 22:03
The Diff Versions button, More Options menu, its Delete File item, the Differ's version selects/Load/Save Version buttons, and the Delete dialog's root and Cancel button had no stable selector, making them untestable. Additive only — no behavior changes.
Extends seed:code to accept {path, overrides} alongside the existing
string-path form, so a test can merge in a value only known at runtime
(e.g. a disposable contentModelZUID) without a hardcoded fixture value.
Backward compatible with the existing string-arg call site.
Adds the editor-suggestions fixture used by the new "Show suggestions"
Cypress coverage.
Closes out the remaining items on this PR's coverage checklist: unsaved status on edit, Save, Publish, Show Diff, the unsaved-exit confirmation dialog, Delete File, and Monaco's field-name autocomplete suggestions.
geodem127
force-pushed
the
test/code-app-data-seeding
branch
from
July 27, 2026 22:29
9b6cad5 to
95613a6
Compare
finnar-bin
requested changes
Jul 27, 2026
geodem127
force-pushed
the
test/code-app-data-seeding
branch
2 times, most recently
from
July 31, 2026 13:54
a16aa6a to
2380098
Compare
…ture Drop the unused editor-suggestions fixture in favor of reusing editor.json (nothing about the suggestions test depends on fixture content or view type), and inline the DifferActions SelectDisplayProps casts instead of hoisting them to module-level constants. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
agalin920
approved these changes
Aug 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NOTE: This work is based on and requires #3899 to be merged first.
Closing out the remaining 7 checklist items (no GitHub issue backs this PR — planned directly from the checklist above). All 7 behaviors already existed in the app; this is purely new Cypress coverage in
cypress/e2e/code/editor.spec.js, plus small additivedata-cyattributes on the Diff Versions button, More Options menu/Delete File item, Differ version selects/Load/Save Version buttons, and the Delete dialog (no behavior changes).Known follow-up, not a blocker: ad hoc manual UI verification against the live dev instance hit a one-off case where the Publish button didn't visually flip to "Published" immediately after a successful publish (toast + 200 response confirmed), while the underlying Cypress "Publish" test itself passes reliably. Looks like a pre-existing eventual-consistency gap between the publish/purge-cache call and the live-status refetch, likely surfaced by repeated automated hits against the shared dev instance rather than a regression from this change.