test: unique artifact filenames to fix a race under paratest - #209
Open
Amoifr wants to merge 1 commit into
Open
Conversation
paratest --functional runs test methods concurrently, and the tests saving source files all wrote to the same var/browser/source path: one test could read the file another test just wrote, failing with the other test's content. Seen on CI where can_save_formatted_json_source and can_save_source_when_exception each read the other's output. Each save now uses a unique filename.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
paratest --functionalruns test methods concurrently, and the file-saving tests all write to the samevar/browser/sourcepaths.catchFileContents()removes the file, runs the callback, then reads it back, so one test can read the file another test just wrote.Seen on this run (#208's first CI pass):
can_save_formatted_json_sourcefailed with the exception dump fromcan_save_source_when_exceptionon one job, and the mirror image on another. The two tests come from theKernelBrowserTeststrait, so two classes race on the samesource.txteven across classes.Each save now uses a unique filename (
random_bytesprefix). With the fix I could no longer reproduce anycan_save_*failure across 8 localparatest --functionalruns.