feat(playwright): use the playwright bundle configuration when registered - #206
Merged
Merged
Conversation
…ered The client was built with four arguments, so the bundle asset server, base url and intercepted hosts were ignored. Without the asset server, assets 404 in an app whose test env runs with `APP_DEBUG=0`.
kbond
force-pushed
the
require-playwright-bundle
branch
from
August 24, 2026 15:56
1784ad4 to
f28ab44
Compare
kbond
changed the title
PlaywrightBrowser
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HasBrowserbuilt the client with four arguments, so everything after them defaulted to null: the bundle'sAssetServer,playwright.base_urlandplaywright.intercepted_hostswere all ignored.PlaywrightTestCaseresolves them from the container, so behaviour differed by entry point.The asset server is the one that hurts. It serves AssetMapper output without going through the kernel, and
framework.asset_mapper.serverdefaults to%kernel.debug%, so an app whose test env runs withAPP_DEBUG=0had every css and js request 404 - unstyled page, no javascript, which is the whole point of using a real browser.The bundle stays optional: its configuration is used when it is registered and enabled, and its absence falls back to the previous defaults. The fixture app registers it, so the existing playwright tests now run through the resolved asset server, base url and intercepted hosts.
Closes #204. Thanks @ker0x for the diagnosis - it was accurate down to the service definition.