Review-only: runtime integration review fixes - #18
Draft
angelol wants to merge 11 commits into
Draft
Conversation
Add external-call runtime execution through configured extension services, including submission dispatch, validation replay, prepared-transaction result propagation, error reporting, and protocol-version gating. This completes the Canton runtime side of external-call support on top of the extension-service branch.
Style cleanups in the external-call validation path, no behavior change: - Move the MonadUtil import to the top of TransactionConfirmationResponsesFactory. - Sort parties via the implicit Ordering[LfPartyId] instead of .sortBy(_.toString). - Order abstains via a dedicated Ordering using ViewPosition.orderViewPosition instead of viewPosition.toString, dropping a redundant intermediate sort. - Replace the string-concatenation tiebreaker in orderInconsistency with a proper Ordering[Seq[ExternalCallOccurrence]]. - Replace Eval.later + .value with a lazy val in ModelConformanceChecker. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
The (extensionId, functionId, config, input) sort tuple was rebuilt inline in three places. Define a single implicit Ordering[ExternalCallKey] on the companion and reuse it from orderInconsistency, orderRecordedResultDisagreement, and the validation key sort. No behavior change: Ordering.by over the same field tuple produces identical lexicographic ordering. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
angelol
force-pushed
the
angelol/external-call-06-runtime-integration-redesign
branch
2 times, most recently
from
June 29, 2026 13:47
1bf7552 to
506e532
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Review-only PR for the runtime-integration review-fixes branch.
This PR contains the follow-up changes addressing upstream review feedback on the branch-06 external-call runtime integration, stacked on top of
angelol/external-call-06-runtime-integration-redesign.Key changes:
Validation
Focused validation was run while addressing the review findings, including:
community-participant/Test/testOnly com.digitalasset.canton.participant.protocol.validation.ExternalCallConsistencyCheckerTest com.digitalasset.canton.participant.protocol.validation.TransactionConfirmationResponsesFactoryExternalCallTestcommunity-participant/scalafmtCheck; community-participant/Test/scalafmtCheckgit diff --checkThis is an internal review PR and is not intended to be merged directly.