refactor(external-call): redesign extension service branch - #14
Draft
angelol wants to merge 13 commits into
Draft
Conversation
Reference commit: c1bea84
angelol
force-pushed
the
angelol/external-call-05-extension-service-redesign
branch
from
May 28, 2026 09:16
c89a458 to
bbf3171
Compare
* [main] Update 2026-05-28.15 Reference commit: 18597a3 * Updated docker image for Canton builds
…sults (digital-asset#526) * feat(external-call): Add Canton protocol support for external calls - Extend ActionDescription with external call results - Update participant_transaction.proto - Update ViewParticipantData - Update NodeHashBuilder for external call hashing * refactor(external-call): redesign protocol carrier after review --------- Co-authored-by: Tino Rusch <tino.rusch@gmail.com>
angelol
force-pushed
the
angelol/external-call-05-extension-service-redesign
branch
2 times, most recently
from
June 2, 2026 22:36
2a0fd26 to
f8176d8
Compare
* [main] Update 2026-06-16.22 Reference commit: a3def04 * Updated docker image for Canton builds
angelol
force-pushed
the
angelol/external-call-05-extension-service-redesign
branch
from
June 22, 2026 11:12
7aee556 to
8595212
Compare
angelol
force-pushed
the
angelol/external-call-05-extension-service-redesign
branch
from
June 28, 2026 17:56
becd47b to
140a808
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Restacks the extension-service branch on top of the redesigned 04 protocol carrier and cleans up the external-call HTTP client surface.
Key branch-05 changes:
X-Request-Idrequest headerIdempotency-Keyacross retriesRetry-Afteras a minimum delayThis branch is stacked on the 04 redesign, so the diff against canonical
external-call/05-extension-servicealso includes the 04 protocol-carrier redesign that is being reviewed separately in PR #13.Validation
git diff --check external-call/05-extension-service...HEAD.HttpExtensionServiceClientTestand participant scalafmt checks during implementation.Full sbt/protobuf validation was not rerun in this PR-opening step.