Friend-share email: temporal debounce (fix silent suppression) - #694
Merged
Conversation
The count-based rule (email only when unread==1) had a sharp edge: a single un-opened share silenced ALL future share emails to that friend until they zeroed their inbox. Replace with a temporal debounce — suppress only if an EARLIER share reached the recipient within SHARE_EMAIL_DEBOUNCE_MINUTES (10). Collapses a burst to one email; a genuinely later share still notifies. Keyed on id order so a simultaneous burst can't suppress all its members. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
ArchLens - No architecturally relevant changes to the existing views |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up. The old
unread==1email rule meant a single un-opened share silenced every future share email to that friend until they cleared their inbox (diagnosed live on prod). Replace with a temporal debounce: suppress only if an earlier share reached the recipient within 10 min. Collapses a burst to one email; a genuinely later share notifies. Race-free (keyed on id order). +3 tests.🤖 Generated with Claude Code