Friend-share email: personalized title, delivery language, deep-links - #693
Merged
Conversation
- Title from the recipient's personalized copy (their language), not the
source-language canonical.
- Deep-link straight to their adapted read (?id=<delivery_article>&shared=<id>),
and point to the Shared inbox for any others — instead of a bare inbox URL.
- Name the language it was prepared in ('in Danish, at your level').
- Reword to 'shared the following article'. Falls back to the canonical
article when there's no derivative.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
ArchLens - No architecturally relevant changes to the existing views |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #690/#691/#692. Improves the share-notification email: title from the recipient's personalized copy (their language), a deep-link straight to their adapted read (
?id=<delivery_article>&shared=<id>, opens in-app and marks read) plus a pointer to the Shared inbox for any others, names the delivery language, and rewords to 'shared the following article'. Falls back to the canonical article when there's no derivative.Pairs with zeeguu/web#1203 (reader mark-read on
?shared=+ the /articles/shared universal-link path).🤖 Generated with Claude Code