Skip to content

Added has_leaderboard to cohort - #668

Open
gabortodor wants to merge 6 commits into
masterfrom
feature/cohort_additions
Open

Added has_leaderboard to cohort#668
gabortodor wants to merge 6 commits into
masterfrom
feature/cohort_additions

Conversation

@gabortodor

Copy link
Copy Markdown
Contributor

No description provided.

@github-actions

github-actions Bot commented Jul 5, 2026

Copy link
Copy Markdown

ArchLens detected architectural changes in the following views:
diff

@mircealungu

Copy link
Copy Markdown
Member

ehi mr @gabortodor . i see a draft here. what's the status?

@gabortodor

Copy link
Copy Markdown
Contributor Author

ehi mr @gabortodor . i see a draft here. what's the status?

Hi, we have some time to work on the project once again, so hopefully this PR will be mergeable in the following days

@klnyzzz33

klnyzzz33 commented Jul 27, 2026

Copy link
Copy Markdown
Contributor

@mircealungu we're finished with the has_leaderboards changes, now the teacher can control whether the classroom's students will see the classroom leaderboard or not. See the frontend PR as well.

We also fixed a small issue that we were aware of with the friend streaks, where it did not increment properly for the very first time.

The last thing remaining that has to be decided, is whether or not the existing users should get their previously earned "hidden" achievements, or start over. Because currently only the newly signed up users get the gamification features, as per our discussion with you:

def _gamification(user: User):
    ...

    if user.id>6479:
        return True

    # Disabled for everyone else
    return False

@klnyzzz33 klnyzzz33 changed the title Added has_recommendations and has_leaderboard to cohort Added has_leaderboard to cohort Jul 27, 2026
@gabortodor
gabortodor marked this pull request as ready for review July 27, 2026 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants