fix: wait for wallet scan completion before balance assertions - #199
Open
schell wants to merge 1 commit into
Open
fix: wait for wallet scan completion before balance assertions#199schell wants to merge 1 commit into
schell wants to merge 1 commit into
Conversation
schell
force-pushed
the
fix/wallet-scan-lag
branch
from
August 28, 2026 03:28
8cfefda to
5215f53
Compare
wait_for_wallet_sync now checks fully_synced_height from getwalletstatus, not just wallet_tip. The transparent balance summary (z_gettotalbalance, z_listtransactions) lags one block behind the wallet tip, so assertions now expect tip - 1 coinbases instead of a tolerance range of 5. Adds timing logs to wait_for_total_balance so convergence patterns are visible in CI output. Timeouts bumped to 600s to diagnose slow CI. Closes #198. Co-Authored-By: Claude <noreply@anthropic.com>
schell
force-pushed
the
fix/wallet-scan-lag
branch
from
August 28, 2026 07:24
5215f53 to
7a17ee0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #198.
wait_for_wallet_syncnow checksgetwalletstatus.fully_synced_height(the height the wallet has actually scanned to), not justwallet_tip. The transparent balance summary (z_gettotalbalance,z_listtransactions) lags one block behind the wallet tip, so assertions now expecttip - 1coinbases with polling instead of a tolerance range of 5.