Replace deprecated datetime.utcnow() in the certificate builder (Python 3.12+) - #20
Open
MBK-fr wants to merge 1 commit into
Open
Replace deprecated datetime.utcnow() in the certificate builder (Python 3.12+)#20MBK-fr wants to merge 1 commit into
MBK-fr wants to merge 1 commit into
Conversation
….12+) The self-signed certificate builder uses datetime.datetime.utcnow() for not_valid_before/not_valid_after. utcnow() is deprecated since Python 3.12 and scheduled for removal. Replaced with datetime.datetime.now(timezone.utc). The values still denote the same UTC instants, and passing timezone-aware datetimes to cryptography's not_valid_before/after is the recommended form (it also silences cryptography's own naive-datetime deprecation warning).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
certsync/entry.pybuilds the self-signed certificate withdatetime.datetime.utcnow()fornot_valid_beforeandnot_valid_after.Why
utcnow()is deprecated since Python 3.12 and scheduled for removal (DeprecationWarning at runtime). Separately,cryptographynow deprecates naive datetimes passed tonot_valid_before/after.Fix
Replaced with
datetime.datetime.now(timezone.utc). The two calls still denote the same UTC instants (minus 1 day / plus 365 days), and passing timezone-aware datetimes is the recommended form forcryptography, so this also removes its naive-datetime warning. Compiles clean; two lines.