CI: set an explicit python-version for test-crc32c and test-zarr - #856
Open
glaziermag wants to merge 1 commit into
Open
CI: set an explicit python-version for test-crc32c and test-zarr#856glaziermag wants to merge 1 commit into
glaziermag wants to merge 1 commit into
Conversation
Both jobs passed `${{ matrix.python-version }}` to setup-python, but
neither matrix defines that key, so they have run on the runner's system
Python since zarr-developers#839. Pin 3.13, restoring the pre-zarr-developers#839 interpreter.
Closes zarr-developers#855.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sets an explicit
python-version: "3.13"on the setup-python steps of thetest-crc32candtest-zarrjobs, restoring the interpreter they were pinned to before #839. Since that PR, both jobs pass${{ matrix.python-version }}to setup-python while neither matrix defines the key, so all six variants have been running on the runner's system Python (3.12.3) — details and log evidence in #855.Closes #855.
Happy to switch this to a
python-versionmatrix axis instead if version × variant coverage is preferred.TODO:
AI assistance was used; the two-line diff and the affected job logs were re-checked by hand.