fix(footer): stop the links row orphaning, move account deletion into Settings - #640
Open
dmnyc wants to merge 1 commit into
Open
fix(footer): stop the links row orphaning, move account deletion into Settings#640dmnyc wants to merge 1 commit into
dmnyc wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two related footer changes.
1. The links row no longer orphans
Before:
⚡ Support · About · Founders · Sponsors · Report a Bug · Terms · Privacy · Safety · Delete Account— thenDisclosurealone on a second line.Two causes, both fixed:
Separators were their own flex items. Each
<span class="footer-sep">·</span>sat in the flex flow as an independent element, so every dot was its own wrap opportunity — a break could strand a·at the end of a line or leave a single link on the next. They're now::afterpseudo-elements on the links themselves, so a link and its trailing dot always move together. Spacing is unchanged (the0.5remthat used to come from the flex gap now comes from the pseudo-element'smargin-left, with the gap still separating items).One item too many. Removing "Delete Account" (see below) takes the row from 9 items to 8 wide ones.
Measured after the change:
It still wraps when genuinely too narrow — that's what wrapping is for — but it now breaks between links and never leaves a separator hanging.
2. Account deletion moved into Settings
"Delete Account" sat in the footer between "Safety" and "Disclosure", styled identically to the terms/privacy links. An irreversible account action shouldn't read as an ordinary utility link, and Settings is where people look for it.
It's now at the end of Settings → Security, as a red action with a short explanation:
That caveat is worth stating up front: the
/delete-accountroute is unchanged and still does exactly what it did, but the footer link gave no hint about what deletion can and can't reach.Verification
pnpm check— 1 error / 152 warnings, identical tomain(pre-existingdelete-operator error)pnpm test— 1267 passedWorth a look on a real phone — my narrow-width numbers come from constraining the container in the page rather than an actual mobile viewport.