Skip to content

fix(footer): stop the links row orphaning, move account deletion into Settings - #640

Open
dmnyc wants to merge 1 commit into
zapcooking:mainfrom
dmnyc:fix/footer-wrap-and-delete-account
Open

fix(footer): stop the links row orphaning, move account deletion into Settings#640
dmnyc wants to merge 1 commit into
zapcooking:mainfrom
dmnyc:fix/footer-wrap-and-delete-account

Conversation

@dmnyc

@dmnyc dmnyc commented Aug 20, 2026

Copy link
Copy Markdown
Collaborator

Two related footer changes.

1. The links row no longer orphans

Before: ⚡ Support · About · Founders · Sponsors · Report a Bug · Terms · Privacy · Safety · Delete Account — then Disclosure alone on a second line.

Two causes, both fixed:

Separators were their own flex items. Each <span class="footer-sep">·</span> sat in the flex flow as an independent element, so every dot was its own wrap opportunity — a break could strand a · at the end of a line or leave a single link on the next. They're now ::after pseudo-elements on the links themselves, so a link and its trailing dot always move together. Spacing is unchanged (the 0.5rem that used to come from the flex gap now comes from the pseudo-element's margin-left, with the gap still separating items).

One item too many. Removing "Delete Account" (see below) takes the row from 9 items to 8 wide ones.

Measured after the change:

Container width Result
Default (42rem) 1 line, no wrap
520px 7 + 2
380px 4 + 5
300px 4 + 4 + 1

It still wraps when genuinely too narrow — that's what wrapping is for — but it now breaks between links and never leaves a separator hanging.

2. Account deletion moved into Settings

"Delete Account" sat in the footer between "Safety" and "Disclosure", styled identically to the terms/privacy links. An irreversible account action shouldn't read as an ordinary utility link, and Settings is where people look for it.

It's now at the end of Settings → Security, as a red action with a short explanation:

Request removal of your account data from zap.cooking. Your Nostr identity and any notes already published to relays are not affected — they aren't ours to delete.

That caveat is worth stating up front: the /delete-account route is unchanged and still does exactly what it did, but the footer link gave no hint about what deletion can and can't reach.

Verification

  • pnpm check — 1 error / 152 warnings, identical to main (pre-existing delete-operator error)
  • pnpm test — 1267 passed
  • Checked in a browser: footer renders on one line at desktop width; wrap points measured at 520/380/300px as above

Worth a look on a real phone — my narrow-width numbers come from constraining the container in the page rather than an actual mobile viewport.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant