Record reviewed provider contract drift - #505
Merged
Merged
Conversation
zackbart
commented
Aug 26, 2026
zackbart
left a comment
Owner
Author
There was a problem hiding this comment.
APPROVE
Independent audit of commit 843e676 found no blocking issues.
- The diff contains exactly 18 contract digest replacements and no other file changes.
- An independent canonicalization and SHA-256 computation against Cloudflare OpenAPI snapshot 31bec32 reproduced the recorded ruleset GET and zone-setting GET/PATCH hashes exactly.
- The same independent computation against Notion's current official OpenAPI reproduced the data-source query hash exactly.
- Both the pinned-source drift run named in this PR and a fresh live-source drift run report zero findings across Cloudflare's 49 and Notion's 14 touched endpoints. Cloudflare main still resolves to 31bec32.
- Issues #498 through #504 are all open, have no closing PR attached, and collectively account for all 18 rows: eight R2, four KV, Worker list, Worker settings, ruleset read, two zone-setting operations, and Notion query.
- The manifest update does not close or claim to implement those issues. No safety classification changed.
GitHub would not accept a formal approval because the current authenticated account authored the PR, so this is submitted as a review comment with the verdict stated explicitly.
zackbart
commented
Aug 26, 2026
zackbart
left a comment
Owner
Author
There was a problem hiding this comment.
APPROVE verdict for commit 843e676. GitHub does not permit this authenticated account to submit a formal approval on its own PR.
Verified:
- The diff changes only two drift manifests.
- It contains exactly 18 contract digest replacements: 17 Cloudflare and one Notion. No method, path, revision, deprecation flag, endpoint order, or other manifest data changed.
- Recomputing against Cloudflare OpenAPI commit 31bec32 and the current Notion OpenAPI reports zero findings across 49 and 14 touched endpoints.
- All eight R2 old digests match the previously reviewed Cloudflare snapshot. All eight new digests match the pinned current snapshot.
- The R2 structural deltas are exactly the addition of
ustocf-r2-jurisdictionon all eight endpoints and to the bucket result enum on the four bucket-returning endpoints. No reviewed R2 delta was omitted or mis-recorded. - Issues #498 through #504 remain open. The PR has no closing issue references, and neither its body nor commit message uses a closing keyword.
No blocking findings.
Owner
Author
|
Independent test at exact commit Verification passed:
Blocker verdict: none. This PR is safe to merge before publishing 0.20.0. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Record the 18 provider contract changes reviewed during the 0.20.0 release drift check:
usjurisdiction across eight endpoints.verification.does_not_equal.The product gaps and provider ambiguity remain durable in #498, #499, #500, #501, #502, #503, and #504. This PR records the reviewed contracts only. It does not claim those follow-ups are implemented or close their issues.
Release verdict
Independent review found every change additive, passthrough-compatible, or limited to a new optional named-tool value with a raw API fallback. No existing request narrowed, no result path broke, and no safety classification changed. None blocks 0.20.0.
Verification
npm run drift:check -- --specs --spec cloudflare=https://raw.githubusercontent.com/cloudflare/api-schemas/31bec32e87cde4854773d2a5edb405f00eb7a468/openapi.json --spec notion=https://developers.notion.com/openapi.json