Refactor master key management and validation logic - #34
Open
zHd4 wants to merge 3 commits into
Open
Conversation
- Move validation logic from `CryptoSecrets` to a dedicated `CryptoSecretsValidator` class. - Update `AppSecurityService` to generate master keys independently of `CryptoSecrets` via `generateMasterKey()`. - Standardize naming in `KeyUtils` for hex conversions. - Refactor `SetupKeyActivity` and `ImportKeyActivity` to handle raw key bytes and improve security by deferring password retrieval. - Ensure proper activity lifecycle management in `AuthActivityExtension` by explicitly finishing activities after navigation. - Update unit and instrumented tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CryptoSecretsto a dedicatedCryptoSecretsValidatorclass.AppSecurityServiceto generate master keys independently ofCryptoSecretsviagenerateMasterKey().KeyUtilsfor hex conversions.SetupKeyActivityandImportKeyActivityto handle raw key bytes and improve security by deferring password retrieval.AuthActivityExtensionby explicitly finishing activities after navigation.