Allow a profile to create multiple render passes by tweak-wtf · Pull Request #104 · ynput/ayon-resolve

tweak-wtf · 2026-06-12T13:55:04Z

Changelog Description

This draft shall make it possible to render more than 1 representation per instance.
Also it aims at making source clip integration optional.

General goal of this is to make use of resolve rendering engine as much as possible to not needing to go through extract_review as this comes with performance penalties compared to resolve.

Additional review information

changes profile structure to allow multiple representations to be rendered
adds Upload as reviewable tag (really just webreview under the hood)

I tested this for plate and editorial_pkg products on windows only.

Testing notes:

build & upload the addon
configure more than 1 representation pass
publish and check for your expected output

…single-profile

Copilot

Pull request overview

This PR updates the Resolve publish settings/schema and extraction logic to support rendering multiple representations (“render passes”) per instance, and introduces an additional representation tag intended for a “reviewable upload” workflow.

Changes:

Extends publish profile settings to define multiple render-pass entries per product base type (plate/editorial_pkg), with shared representation attributes.
Updates ExtractProductResources to iterate over multiple output settings and optionally disable “clip source” representation integration.
Adds a new representation tag option: webreview (“Upload as reviewable”).

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 5 comments.

File	Description
server/settings.py	Adds new settings models/structure to support multiple render-pass entries and introduces the `webreview` tag; defaults block was commented out.
client/ayon_resolve/plugins/publish/extract_product_resources.py	Updates extraction to handle multiple passes, adds optional clip source integration behavior, and normalizes new nested settings structure.

Comments suppressed due to low confidence (1)

client/ayon_resolve/plugins/publish/extract_product_resources.py:157

get_default_settings doesn't include required keys like name/tags/custom_tags (and with_handles for plates). When defaults are used, later code accesses settings['name'] and will raise a KeyError.

    def get_default_settings(self, product_base_type="editorial_pkg"):
        """Return hard-coded defaults when no matching preset is found."""
        if product_base_type == "plate":
            return {
                "file_format": "EXR",
                "codec":       "RGB half (DWAA)",
                "preset_path": (
                    "{ayon_render_presets}/clip/EXR_RGB_half_(DWAA).xml"
                ),
            }
        return {
            "file_format":   "QuickTime",
            "codec":         "H.264",
            "preset_path":   (
                "{ayon_render_presets}/timeline/QuickTime_H264.xml"
            ),
            "export_otio": True,
            "otio_rootless": True,
        }

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

tweak-wtf · 2026-07-27T13:03:35Z

+        result = []
+        for preset in profile.get(product_base_type, []):
+            normalized = self._normalize_preset(preset)
+            result.append(normalized)


adressed in e988bfb

settings now validate for unique representation names per repre of each profile

tweak-wtf · 2026-07-22T15:08:31Z

        normalized = {
-            "name":        preset["name"],
+            "name":        preset["shared"]["repre_name"],
            "file_format": fmt.get("format"),
            "codec":       fmt.get("codec"),
            "preset_path": fmt.get("preset_path"),
-            "with_handles": sub.get("with_handles"),
-            "tags":        preset["tags"],
-            "custom_tags": preset["custom_tags"],
+            "with_handles": preset["settings"].get("with_handles"),
+            "tags":        preset["shared"]["tags"],
+            "custom_tags": preset["shared"]["custom_tags"],
+            "export_otio": preset["settings"].get("export_otio", None),
+            "otio_rootless": preset["settings"].get("otio_rootless", None),
        }


hm i wouldn't add colorspace here.
i think handling colorspaces and their conversion here ends up being convoluted and not flexible.

i'm running an approach where i give artists a toggle to enable/disable "Post ColorGroup" in resolve directly before render triggers.
that way the artist can use vanilla resolve to do linearization.
but that's not in this PR. can open it up if there is interest tho

having said that we might completely remove colorspace from server settings.
not sure what the original intent behind this is

BigRoy · 2026-07-22T08:30:06Z

+
+        return (profile["integrate_clip_source"], result)
+
+    def _normalize_preset(self, preset):


Would it make more sense for this to return a dataclass? So that the process methods also take these dataclasses? Would probably make the code way more sane?

tbh i only used what was already there trying to be minimally invasive.

but sure. refactor everything preset related into 1 dataclass. can do that ✌️

Happy to do so in separate PR though @jakubjezek001 ?

alrighty, then i'll continue to adress the notes where possible and eventually set this to be ready for review.
on that note thanks for checking this out already

BigRoy · 2026-07-22T08:31:59Z

+        # todo: find the source of this, i think it's some otio extractor
+        #       maybe skip adding the repre there? but settings would be in a different extractor... doesn't make sense
+        if not integrate_clip_source:
+            instance.data["representations"] = []   # disables clip source integration


Isn't this just a matter of tagging the repres with a delete tag? 🤔

tried it just now but unfortunately no :/
the main issue here is this

i have a r3d file as source that i'm trying to publish as exr

Collect OTIO Subset Resources picks up the r3d and adds it as representation

Extract OTIO trim longer video kicks in failing with ffprobe error Invalid data found when processing input

since the r3d is still a representation it will be integrated

doesn't really make sense as u don't want to integrate the cam source, only the plates thatw ere rendered from it before

since i haven't found any settings in ayon-core for those 2 otio related plugins i made this admittedly ugly af workaround.
should i add server settings for the otio plugins in ayon-core to e.g. remove resolve from the hosts?
if the collector never runs it will also never add the cam source as representation right 🤷

should i add server settings for the otio plugins in ayon-core to e.g. remove resolve from the hosts? if the > collector never runs it will also never add the cam source as representation right 🤷

You may want to check out #109

I think it overlaps?

i tried with the changes in #109 but to no avail :/

the main issue is that Collect OTIO Subset Resources will always run and will always add the source media to this instance's representations.

i kinda see 3 options here:

make Collect OTIO Subset Resources optional in ayon-core

add e.g. skip_otio bool to instance.data during creation and respect this in the otio subset collector

keep it as is in this PR

kinda leaning towards option 1 tbh but would require a new PR.

thoughts on this @BigRoy ?

BigRoy · 2026-07-22T08:34:45Z

-                "ExtractProductResources: unhandled product base type '%s', skipping.", product_base_type
-            )
+            # set rendering logger to inherit from publisher's logger
+            rendering.log = self.log


I know this isn't new - but this changes the module-level log variable and will keep it changed after this has run. If easy to fix, would be good to clean that up.

just tested without the module-level log override.
it causes the logs from ayon_resolve.api functions to not be visible in the publisher's details pane. however, the resolve console still prints them.

imho we can remove it completely. afaik other addons' api functions also don't propagate to the publisher.

does this open up the general logging can of worms?

…single-profile

…er settings

sync from internal repo

5e204d9

jakubjezek001 added type: enhancement Improvement of existing functionality or minor addition community Issues and PRs coming from the community members labels Jun 23, 2026

jakubjezek001 self-assigned this Jun 23, 2026

Merge branch 'develop' into contrib/multi-representation-render-from-…

c6d385e

…single-profile

jakubjezek001 requested a review from Copilot July 22, 2026 08:15

Copilot started reviewing on behalf of jakubjezek001 July 22, 2026 08:15 View session

Copilot AI reviewed Jul 22, 2026

View reviewed changes

BigRoy reviewed Jul 22, 2026

View reviewed changes

tweak-wtf and others added 5 commits July 22, 2026 12:27

Merge branch 'develop' into contrib/multi-representation-render-from-…

2328a6d

…single-profile

removes early return if no task is there as this scenario is impossible

72ff09d

raises if no profile is found instead of returning hardcoded defaults

90c9ffa

removes now unused 'get_default_settings' and configures default serv…

307b31b

…er settings

validate for unique representation names

e988bfb

tweak-wtf marked this pull request as ready for review July 27, 2026 13:04


		return (profile["integrate_clip_source"], result)

		def _normalize_preset(self, preset):

Uh oh!

Conversation

tweak-wtf commented Jun 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changelog Description

Additional review information

Testing notes:

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

tweak-wtf Jul 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

tweak-wtf commented Jun 12, 2026 •

edited

Loading

tweak-wtf Jul 22, 2026 •

edited

Loading