Setting conversion: Fix UnboundLocalError on extract_review_intermediates variable - #355
Merged
iLLiCiTiT merged 1 commit intoAug 19, 2026
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes settings-conversion failure when copying older Nuke addon settings that don’t include publish.ExtractReviewIntermediates, preventing an UnboundLocalError during conversion and allowing the rest of the publish overrides to be copied successfully.
Changes:
- Add an early return in
_convert_extract_intermediate_files_0_2_3whenExtractReviewIntermediatesis not present. - Move
extract_review_intermediatesassignment outside the previous conditional so it’s always defined when used.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
iLLiCiTiT
approved these changes
Aug 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog Description
Setting conversion: Fix #354 UnboundLocalError on
extract_review_intermediatesvariableAdditional review information
Settings conversion should work.
Testing notes:
ExtractReviewIntermediatesbut DOES have overrides to other plug-ins underpublishsection.