Collect frames fix: Move collect frames fix plugin to nuke integration - #334
Draft
iLLiCiTiT wants to merge 4 commits into
Draft
Collect frames fix: Move collect frames fix plugin to nuke integration#334iLLiCiTiT wants to merge 4 commits into
iLLiCiTiT wants to merge 4 commits into
Conversation
iLLiCiTiT
added
the
type: enhancement
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog Description
Move
CollectFrameFixDeffrom core addon to nuke addon.Additional review information
The plugin in core addon has only
"nuke"in hosts. It's filters by families make it "not generic".This is a proposal for ynput/ayon-core#1964 would need a PR in ayon-core too which would stop returning attribute definitions when this plugin would be available.
This move should be backwards compatible. There is no step back in case this change was used on a workfile where is newer core, once this plugin does store it's values to the workfile it will always show the new plugin. But if there is core addon that does define
CollectFrameFixDefand it returns attribute definitions the new plugin here is skipped.So technically both core and nuke has to be updated to start use the plugin. From that moment studio should not revert back as it would not convert the values from core's plugin to nuke's plugin.
Alternative solution
Change core's plugin to unified family and define the families in nuke. BUT There already is a custom plugin for houdini
Testing notes: