reviewable batch render - #146
Open
miravassor wants to merge 2 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR makes “reviewable” Batch Render instances work end-to-end in the Flame publish pipeline: the creator exposes a Review toggle (default off) and persists it on the instance, the collector adds the review family and frame range metadata needed for review extraction, and the extractor tags the produced representation accordingly.
Changes:
- Expose/store a
reviewcreator attribute for Batch Render instances and use it to add thereviewfamily during collection. - Collect frame range (
frameStart/frameEnd) andfpsfrom the Write File node/context for downstream review extraction requirements. - Refactor Write File node lookup into a shared API helper and tag extracted representations with
reviewwhen applicable.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| client/ayon_flame/plugins/publish/extract_batch_render.py | Uses shared Write File node lookup, improves publish error type, and tags representations as review when the instance is reviewable. |
| client/ayon_flame/plugins/publish/collect_render_from_batch.py | Adds review family based on creator attributes and collects frame range + fps needed for review extraction. |
| client/ayon_flame/plugins/create/create_batch_render.py | Adds Review toggle to pre-create attributes (default off) and persists it into creator_attributes. |
| client/ayon_flame/api/menu.py | Defers publisher UI invocation correctly by wrapping calls in lambdas. |
| client/ayon_flame/api/batch_utils.py | Adds get_write_node_from_batch helper for consistent Write File node discovery. |
| client/ayon_flame/api/init.py | Exposes the new get_write_node_from_batch helper in the public API exports. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+105
to
108
| raise PublishError( | ||
| f"Expected {resolved_path} files is not found " | ||
| "in output directory." | ||
| ) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Review toggle on the Batch Render creator now works. It is exposed in the pre-create attributes, defaults to off, and is stored on the instance. When enabled, the collector adds the
reviewfamily and the extractor tags the representation withreview.The collector also reads the frame range from the Write File node and collects
frameStart/frameEnd/fps, which review extraction needs.Tested successfully in Flame 2026 :-)