Tools: Update and enhance abstract methods - #1990
Merged
Merged
Conversation
iLLiCiTiT
added
the
type: enhancement
Member
|
Fiddled with Settings in:
(sorted alphabetically, not by task types) |
# Conflicts: # client/ayon_core/tools/publisher/abstract.py # client/ayon_core/tools/publisher/widgets/create_context_widgets.py
Member
Author
Should be fixed now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog Description
Fill missing abstract methods for tools and change how task sorting is received from controller.
Additional info
Some abstract classes were missing abstract methods that are mandatory for tools to work.
Changed how task sorting is received from controller, use dedicated method instead of getting full settings dictionary from the controller. This step was made so we do avoid creating copy of huge dictionary just to get boolean (with this in mind).
Testing notes:
All tools can be showed, are working and tasks are sorted based on sorting from settings.